You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2017/10/03 15:13:52 UTC
[09/34] hbase-site git commit: Published site at .
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/73598816/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.html
index 7351c21..ffb1464 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/EnableTableProcedure.html
@@ -27,322 +27,425 @@
<span class="sourceLineNo">019</span>package org.apache.hadoop.hbase.master.procedure;<a name="line.19"></a>
<span class="sourceLineNo">020</span><a name="line.20"></a>
<span class="sourceLineNo">021</span>import java.io.IOException;<a name="line.21"></a>
-<span class="sourceLineNo">022</span>import org.apache.commons.logging.Log;<a name="line.22"></a>
-<span class="sourceLineNo">023</span>import org.apache.commons.logging.LogFactory;<a name="line.23"></a>
-<span class="sourceLineNo">024</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.24"></a>
-<span class="sourceLineNo">025</span>import org.apache.hadoop.hbase.TableName;<a name="line.25"></a>
-<span class="sourceLineNo">026</span>import org.apache.hadoop.hbase.TableNotDisabledException;<a name="line.26"></a>
-<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.TableNotFoundException;<a name="line.27"></a>
-<span class="sourceLineNo">028</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.28"></a>
-<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.client.TableState;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.master.TableStateManager;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.EnableTableState;<a name="line.35"></a>
-<span class="sourceLineNo">036</span><a name="line.36"></a>
-<span class="sourceLineNo">037</span>@InterfaceAudience.Private<a name="line.37"></a>
-<span class="sourceLineNo">038</span>public class EnableTableProcedure<a name="line.38"></a>
-<span class="sourceLineNo">039</span> extends AbstractStateMachineTableProcedure<EnableTableState> {<a name="line.39"></a>
-<span class="sourceLineNo">040</span> private static final Log LOG = LogFactory.getLog(EnableTableProcedure.class);<a name="line.40"></a>
-<span class="sourceLineNo">041</span><a name="line.41"></a>
-<span class="sourceLineNo">042</span> private TableName tableName;<a name="line.42"></a>
-<span class="sourceLineNo">043</span> private boolean skipTableStateCheck;<a name="line.43"></a>
-<span class="sourceLineNo">044</span><a name="line.44"></a>
-<span class="sourceLineNo">045</span> private Boolean traceEnabled = null;<a name="line.45"></a>
-<span class="sourceLineNo">046</span><a name="line.46"></a>
-<span class="sourceLineNo">047</span> public EnableTableProcedure() {<a name="line.47"></a>
-<span class="sourceLineNo">048</span> super();<a name="line.48"></a>
-<span class="sourceLineNo">049</span> }<a name="line.49"></a>
-<span class="sourceLineNo">050</span><a name="line.50"></a>
-<span class="sourceLineNo">051</span> /**<a name="line.51"></a>
-<span class="sourceLineNo">052</span> * Constructor<a name="line.52"></a>
-<span class="sourceLineNo">053</span> * @param env MasterProcedureEnv<a name="line.53"></a>
-<span class="sourceLineNo">054</span> * @param tableName the table to operate on<a name="line.54"></a>
-<span class="sourceLineNo">055</span> * @param skipTableStateCheck whether to check table state<a name="line.55"></a>
-<span class="sourceLineNo">056</span> */<a name="line.56"></a>
-<span class="sourceLineNo">057</span> public EnableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.57"></a>
-<span class="sourceLineNo">058</span> final boolean skipTableStateCheck) {<a name="line.58"></a>
-<span class="sourceLineNo">059</span> this(env, tableName, skipTableStateCheck, null);<a name="line.59"></a>
-<span class="sourceLineNo">060</span> }<a name="line.60"></a>
-<span class="sourceLineNo">061</span><a name="line.61"></a>
-<span class="sourceLineNo">062</span> /**<a name="line.62"></a>
-<span class="sourceLineNo">063</span> * Constructor<a name="line.63"></a>
-<span class="sourceLineNo">064</span> * @param env MasterProcedureEnv<a name="line.64"></a>
-<span class="sourceLineNo">065</span> * @param tableName the table to operate on<a name="line.65"></a>
-<span class="sourceLineNo">066</span> * @param skipTableStateCheck whether to check table state<a name="line.66"></a>
-<span class="sourceLineNo">067</span> */<a name="line.67"></a>
-<span class="sourceLineNo">068</span> public EnableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.68"></a>
-<span class="sourceLineNo">069</span> final boolean skipTableStateCheck, final ProcedurePrepareLatch syncLatch) {<a name="line.69"></a>
-<span class="sourceLineNo">070</span> super(env, syncLatch);<a name="line.70"></a>
-<span class="sourceLineNo">071</span> this.tableName = tableName;<a name="line.71"></a>
-<span class="sourceLineNo">072</span> this.skipTableStateCheck = skipTableStateCheck;<a name="line.72"></a>
-<span class="sourceLineNo">073</span> }<a name="line.73"></a>
-<span class="sourceLineNo">074</span><a name="line.74"></a>
-<span class="sourceLineNo">075</span> @Override<a name="line.75"></a>
-<span class="sourceLineNo">076</span> protected Flow executeFromState(final MasterProcedureEnv env, final EnableTableState state)<a name="line.76"></a>
-<span class="sourceLineNo">077</span> throws InterruptedException {<a name="line.77"></a>
-<span class="sourceLineNo">078</span> if (isTraceEnabled()) {<a name="line.78"></a>
-<span class="sourceLineNo">079</span> LOG.trace(this + " execute state=" + state);<a name="line.79"></a>
-<span class="sourceLineNo">080</span> }<a name="line.80"></a>
-<span class="sourceLineNo">081</span><a name="line.81"></a>
-<span class="sourceLineNo">082</span> try {<a name="line.82"></a>
-<span class="sourceLineNo">083</span> switch (state) {<a name="line.83"></a>
-<span class="sourceLineNo">084</span> case ENABLE_TABLE_PREPARE:<a name="line.84"></a>
-<span class="sourceLineNo">085</span> if (prepareEnable(env)) {<a name="line.85"></a>
-<span class="sourceLineNo">086</span> setNextState(EnableTableState.ENABLE_TABLE_PRE_OPERATION);<a name="line.86"></a>
-<span class="sourceLineNo">087</span> } else {<a name="line.87"></a>
-<span class="sourceLineNo">088</span> assert isFailed() : "enable should have an exception here";<a name="line.88"></a>
-<span class="sourceLineNo">089</span> return Flow.NO_MORE_STATE;<a name="line.89"></a>
-<span class="sourceLineNo">090</span> }<a name="line.90"></a>
-<span class="sourceLineNo">091</span> break;<a name="line.91"></a>
-<span class="sourceLineNo">092</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.92"></a>
-<span class="sourceLineNo">093</span> preEnable(env, state);<a name="line.93"></a>
-<span class="sourceLineNo">094</span> setNextState(EnableTableState.ENABLE_TABLE_SET_ENABLING_TABLE_STATE);<a name="line.94"></a>
-<span class="sourceLineNo">095</span> break;<a name="line.95"></a>
-<span class="sourceLineNo">096</span> case ENABLE_TABLE_SET_ENABLING_TABLE_STATE:<a name="line.96"></a>
-<span class="sourceLineNo">097</span> setTableStateToEnabling(env, tableName);<a name="line.97"></a>
-<span class="sourceLineNo">098</span> setNextState(EnableTableState.ENABLE_TABLE_MARK_REGIONS_ONLINE);<a name="line.98"></a>
-<span class="sourceLineNo">099</span> break;<a name="line.99"></a>
-<span class="sourceLineNo">100</span> case ENABLE_TABLE_MARK_REGIONS_ONLINE:<a name="line.100"></a>
-<span class="sourceLineNo">101</span> addChildProcedure(env.getAssignmentManager().createAssignProcedures(tableName));<a name="line.101"></a>
-<span class="sourceLineNo">102</span> setNextState(EnableTableState.ENABLE_TABLE_SET_ENABLED_TABLE_STATE);<a name="line.102"></a>
-<span class="sourceLineNo">103</span> break;<a name="line.103"></a>
-<span class="sourceLineNo">104</span> case ENABLE_TABLE_SET_ENABLED_TABLE_STATE:<a name="line.104"></a>
-<span class="sourceLineNo">105</span> setTableStateToEnabled(env, tableName);<a name="line.105"></a>
-<span class="sourceLineNo">106</span> setNextState(EnableTableState.ENABLE_TABLE_POST_OPERATION);<a name="line.106"></a>
-<span class="sourceLineNo">107</span> break;<a name="line.107"></a>
-<span class="sourceLineNo">108</span> case ENABLE_TABLE_POST_OPERATION:<a name="line.108"></a>
-<span class="sourceLineNo">109</span> postEnable(env, state);<a name="line.109"></a>
-<span class="sourceLineNo">110</span> return Flow.NO_MORE_STATE;<a name="line.110"></a>
-<span class="sourceLineNo">111</span> default:<a name="line.111"></a>
-<span class="sourceLineNo">112</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.112"></a>
-<span class="sourceLineNo">113</span> }<a name="line.113"></a>
-<span class="sourceLineNo">114</span> } catch (IOException e) {<a name="line.114"></a>
-<span class="sourceLineNo">115</span> if (isRollbackSupported(state)) {<a name="line.115"></a>
-<span class="sourceLineNo">116</span> setFailure("master-enable-table", e);<a name="line.116"></a>
-<span class="sourceLineNo">117</span> } else {<a name="line.117"></a>
-<span class="sourceLineNo">118</span> LOG.warn("Retriable error trying to enable table=" + tableName +<a name="line.118"></a>
-<span class="sourceLineNo">119</span> " (in state=" + state + ")", e);<a name="line.119"></a>
-<span class="sourceLineNo">120</span> }<a name="line.120"></a>
-<span class="sourceLineNo">121</span> }<a name="line.121"></a>
-<span class="sourceLineNo">122</span> return Flow.HAS_MORE_STATE;<a name="line.122"></a>
-<span class="sourceLineNo">123</span> }<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
-<span class="sourceLineNo">125</span> @Override<a name="line.125"></a>
-<span class="sourceLineNo">126</span> protected void rollbackState(final MasterProcedureEnv env, final EnableTableState state)<a name="line.126"></a>
-<span class="sourceLineNo">127</span> throws IOException {<a name="line.127"></a>
-<span class="sourceLineNo">128</span> // nothing to rollback, prepare-disable is just table-state checks.<a name="line.128"></a>
-<span class="sourceLineNo">129</span> // We can fail if the table does not exist or is not disabled.<a name="line.129"></a>
-<span class="sourceLineNo">130</span> switch (state) {<a name="line.130"></a>
-<span class="sourceLineNo">131</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.131"></a>
-<span class="sourceLineNo">132</span> return;<a name="line.132"></a>
-<span class="sourceLineNo">133</span> case ENABLE_TABLE_PREPARE:<a name="line.133"></a>
-<span class="sourceLineNo">134</span> releaseSyncLatch();<a name="line.134"></a>
-<span class="sourceLineNo">135</span> return;<a name="line.135"></a>
-<span class="sourceLineNo">136</span> default:<a name="line.136"></a>
-<span class="sourceLineNo">137</span> break;<a name="line.137"></a>
-<span class="sourceLineNo">138</span> }<a name="line.138"></a>
-<span class="sourceLineNo">139</span><a name="line.139"></a>
-<span class="sourceLineNo">140</span> // The delete doesn't have a rollback. The execution will succeed, at some point.<a name="line.140"></a>
-<span class="sourceLineNo">141</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.141"></a>
-<span class="sourceLineNo">142</span> }<a name="line.142"></a>
-<span class="sourceLineNo">143</span><a name="line.143"></a>
-<span class="sourceLineNo">144</span> @Override<a name="line.144"></a>
-<span class="sourceLineNo">145</span> protected boolean isRollbackSupported(final EnableTableState state) {<a name="line.145"></a>
-<span class="sourceLineNo">146</span> switch (state) {<a name="line.146"></a>
-<span class="sourceLineNo">147</span> case ENABLE_TABLE_PREPARE:<a name="line.147"></a>
-<span class="sourceLineNo">148</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.148"></a>
-<span class="sourceLineNo">149</span> return true;<a name="line.149"></a>
-<span class="sourceLineNo">150</span> default:<a name="line.150"></a>
-<span class="sourceLineNo">151</span> return false;<a name="line.151"></a>
-<span class="sourceLineNo">152</span> }<a name="line.152"></a>
-<span class="sourceLineNo">153</span> }<a name="line.153"></a>
-<span class="sourceLineNo">154</span><a name="line.154"></a>
-<span class="sourceLineNo">155</span> @Override<a name="line.155"></a>
-<span class="sourceLineNo">156</span> protected EnableTableState getState(final int stateId) {<a name="line.156"></a>
-<span class="sourceLineNo">157</span> return EnableTableState.valueOf(stateId);<a name="line.157"></a>
-<span class="sourceLineNo">158</span> }<a name="line.158"></a>
-<span class="sourceLineNo">159</span><a name="line.159"></a>
-<span class="sourceLineNo">160</span> @Override<a name="line.160"></a>
-<span class="sourceLineNo">161</span> protected int getStateId(final EnableTableState state) {<a name="line.161"></a>
-<span class="sourceLineNo">162</span> return state.getNumber();<a name="line.162"></a>
-<span class="sourceLineNo">163</span> }<a name="line.163"></a>
-<span class="sourceLineNo">164</span><a name="line.164"></a>
-<span class="sourceLineNo">165</span> @Override<a name="line.165"></a>
-<span class="sourceLineNo">166</span> protected EnableTableState getInitialState() {<a name="line.166"></a>
-<span class="sourceLineNo">167</span> return EnableTableState.ENABLE_TABLE_PREPARE;<a name="line.167"></a>
-<span class="sourceLineNo">168</span> }<a name="line.168"></a>
-<span class="sourceLineNo">169</span><a name="line.169"></a>
-<span class="sourceLineNo">170</span> @Override<a name="line.170"></a>
-<span class="sourceLineNo">171</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.171"></a>
-<span class="sourceLineNo">172</span> throws IOException {<a name="line.172"></a>
-<span class="sourceLineNo">173</span> super.serializeStateData(serializer);<a name="line.173"></a>
-<span class="sourceLineNo">174</span><a name="line.174"></a>
-<span class="sourceLineNo">175</span> MasterProcedureProtos.EnableTableStateData.Builder enableTableMsg =<a name="line.175"></a>
-<span class="sourceLineNo">176</span> MasterProcedureProtos.EnableTableStateData.newBuilder()<a name="line.176"></a>
-<span class="sourceLineNo">177</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.177"></a>
-<span class="sourceLineNo">178</span> .setTableName(ProtobufUtil.toProtoTableName(tableName))<a name="line.178"></a>
-<span class="sourceLineNo">179</span> .setSkipTableStateCheck(skipTableStateCheck);<a name="line.179"></a>
-<span class="sourceLineNo">180</span><a name="line.180"></a>
-<span class="sourceLineNo">181</span> serializer.serialize(enableTableMsg.build());<a name="line.181"></a>
-<span class="sourceLineNo">182</span> }<a name="line.182"></a>
-<span class="sourceLineNo">183</span><a name="line.183"></a>
-<span class="sourceLineNo">184</span> @Override<a name="line.184"></a>
-<span class="sourceLineNo">185</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.185"></a>
-<span class="sourceLineNo">186</span> throws IOException {<a name="line.186"></a>
-<span class="sourceLineNo">187</span> super.deserializeStateData(serializer);<a name="line.187"></a>
-<span class="sourceLineNo">188</span><a name="line.188"></a>
-<span class="sourceLineNo">189</span> MasterProcedureProtos.EnableTableStateData enableTableMsg =<a name="line.189"></a>
-<span class="sourceLineNo">190</span> serializer.deserialize(MasterProcedureProtos.EnableTableStateData.class);<a name="line.190"></a>
-<span class="sourceLineNo">191</span> setUser(MasterProcedureUtil.toUserInfo(enableTableMsg.getUserInfo()));<a name="line.191"></a>
-<span class="sourceLineNo">192</span> tableName = ProtobufUtil.toTableName(enableTableMsg.getTableName());<a name="line.192"></a>
-<span class="sourceLineNo">193</span> skipTableStateCheck = enableTableMsg.getSkipTableStateCheck();<a name="line.193"></a>
-<span class="sourceLineNo">194</span> }<a name="line.194"></a>
-<span class="sourceLineNo">195</span><a name="line.195"></a>
-<span class="sourceLineNo">196</span> @Override<a name="line.196"></a>
-<span class="sourceLineNo">197</span> public TableName getTableName() {<a name="line.197"></a>
-<span class="sourceLineNo">198</span> return tableName;<a name="line.198"></a>
-<span class="sourceLineNo">199</span> }<a name="line.199"></a>
-<span class="sourceLineNo">200</span><a name="line.200"></a>
-<span class="sourceLineNo">201</span> @Override<a name="line.201"></a>
-<span class="sourceLineNo">202</span> public TableOperationType getTableOperationType() {<a name="line.202"></a>
-<span class="sourceLineNo">203</span> return TableOperationType.ENABLE;<a name="line.203"></a>
-<span class="sourceLineNo">204</span> }<a name="line.204"></a>
-<span class="sourceLineNo">205</span><a name="line.205"></a>
-<span class="sourceLineNo">206</span><a name="line.206"></a>
-<span class="sourceLineNo">207</span> /**<a name="line.207"></a>
-<span class="sourceLineNo">208</span> * Action before any real action of enabling table. Set the exception in the procedure instead<a name="line.208"></a>
-<span class="sourceLineNo">209</span> * of throwing it. This approach is to deal with backward compatible with 1.0.<a name="line.209"></a>
-<span class="sourceLineNo">210</span> * @param env MasterProcedureEnv<a name="line.210"></a>
-<span class="sourceLineNo">211</span> * @return whether the table passes the necessary checks<a name="line.211"></a>
-<span class="sourceLineNo">212</span> * @throws IOException<a name="line.212"></a>
-<span class="sourceLineNo">213</span> */<a name="line.213"></a>
-<span class="sourceLineNo">214</span> private boolean prepareEnable(final MasterProcedureEnv env) throws IOException {<a name="line.214"></a>
-<span class="sourceLineNo">215</span> boolean canTableBeEnabled = true;<a name="line.215"></a>
-<span class="sourceLineNo">216</span><a name="line.216"></a>
-<span class="sourceLineNo">217</span> // Check whether table exists<a name="line.217"></a>
-<span class="sourceLineNo">218</span> if (!MetaTableAccessor.tableExists(env.getMasterServices().getConnection(), tableName)) {<a name="line.218"></a>
-<span class="sourceLineNo">219</span> setFailure("master-enable-table", new TableNotFoundException(tableName));<a name="line.219"></a>
-<span class="sourceLineNo">220</span> canTableBeEnabled = false;<a name="line.220"></a>
-<span class="sourceLineNo">221</span> } else if (!skipTableStateCheck) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span> // There could be multiple client requests trying to disable or enable<a name="line.222"></a>
-<span class="sourceLineNo">223</span> // the table at the same time. Ensure only the first request is honored<a name="line.223"></a>
-<span class="sourceLineNo">224</span> // After that, no other requests can be accepted until the table reaches<a name="line.224"></a>
-<span class="sourceLineNo">225</span> // DISABLED or ENABLED.<a name="line.225"></a>
-<span class="sourceLineNo">226</span> //<a name="line.226"></a>
-<span class="sourceLineNo">227</span> // Note: in 1.0 release, we called TableStateManager.setTableStateIfInStates() to set<a name="line.227"></a>
-<span class="sourceLineNo">228</span> // the state to ENABLING from DISABLED. The implementation was done before table lock<a name="line.228"></a>
-<span class="sourceLineNo">229</span> // was implemented. With table lock, there is no need to set the state here (it will<a name="line.229"></a>
-<span class="sourceLineNo">230</span> // set the state later on). A quick state check should be enough for us to move forward.<a name="line.230"></a>
-<span class="sourceLineNo">231</span> TableStateManager tsm = env.getMasterServices().getTableStateManager();<a name="line.231"></a>
-<span class="sourceLineNo">232</span> TableState.State state = tsm.getTableState(tableName);<a name="line.232"></a>
-<span class="sourceLineNo">233</span> if(!state.equals(TableState.State.DISABLED)){<a name="line.233"></a>
-<span class="sourceLineNo">234</span> LOG.info("Table " + tableName + " isn't disabled;is "+state.name()+"; skipping enable");<a name="line.234"></a>
-<span class="sourceLineNo">235</span> setFailure("master-enable-table", new TableNotDisabledException(<a name="line.235"></a>
-<span class="sourceLineNo">236</span> this.tableName+" state is "+state.name()));<a name="line.236"></a>
-<span class="sourceLineNo">237</span> canTableBeEnabled = false;<a name="line.237"></a>
-<span class="sourceLineNo">238</span> }<a name="line.238"></a>
-<span class="sourceLineNo">239</span> }<a name="line.239"></a>
-<span class="sourceLineNo">240</span><a name="line.240"></a>
-<span class="sourceLineNo">241</span> // We are done the check. Future actions in this procedure could be done asynchronously.<a name="line.241"></a>
-<span class="sourceLineNo">242</span> releaseSyncLatch();<a name="line.242"></a>
-<span class="sourceLineNo">243</span><a name="line.243"></a>
-<span class="sourceLineNo">244</span> return canTableBeEnabled;<a name="line.244"></a>
+<span class="sourceLineNo">022</span>import java.util.ArrayList;<a name="line.22"></a>
+<span class="sourceLineNo">023</span>import java.util.List;<a name="line.23"></a>
+<span class="sourceLineNo">024</span><a name="line.24"></a>
+<span class="sourceLineNo">025</span>import org.apache.commons.logging.Log;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import org.apache.commons.logging.LogFactory;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.Cell;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.HConstants;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.MetaTableAccessor;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.TableName;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.TableNotDisabledException;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.TableNotFoundException;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.client.Connection;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.client.Get;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.client.RegionReplicaUtil;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.client.Result;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.client.Table;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.client.TableState;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.master.MasterCoprocessorHost;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.master.TableStateManager;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.EnableTableState;<a name="line.47"></a>
+<span class="sourceLineNo">048</span><a name="line.48"></a>
+<span class="sourceLineNo">049</span>@InterfaceAudience.Private<a name="line.49"></a>
+<span class="sourceLineNo">050</span>public class EnableTableProcedure<a name="line.50"></a>
+<span class="sourceLineNo">051</span> extends AbstractStateMachineTableProcedure<EnableTableState> {<a name="line.51"></a>
+<span class="sourceLineNo">052</span> private static final Log LOG = LogFactory.getLog(EnableTableProcedure.class);<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span> private TableName tableName;<a name="line.54"></a>
+<span class="sourceLineNo">055</span> private boolean skipTableStateCheck;<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span> private Boolean traceEnabled = null;<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span> public EnableTableProcedure() {<a name="line.59"></a>
+<span class="sourceLineNo">060</span> super();<a name="line.60"></a>
+<span class="sourceLineNo">061</span> }<a name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span> /**<a name="line.63"></a>
+<span class="sourceLineNo">064</span> * Constructor<a name="line.64"></a>
+<span class="sourceLineNo">065</span> * @param env MasterProcedureEnv<a name="line.65"></a>
+<span class="sourceLineNo">066</span> * @param tableName the table to operate on<a name="line.66"></a>
+<span class="sourceLineNo">067</span> * @param skipTableStateCheck whether to check table state<a name="line.67"></a>
+<span class="sourceLineNo">068</span> */<a name="line.68"></a>
+<span class="sourceLineNo">069</span> public EnableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.69"></a>
+<span class="sourceLineNo">070</span> final boolean skipTableStateCheck) {<a name="line.70"></a>
+<span class="sourceLineNo">071</span> this(env, tableName, skipTableStateCheck, null);<a name="line.71"></a>
+<span class="sourceLineNo">072</span> }<a name="line.72"></a>
+<span class="sourceLineNo">073</span><a name="line.73"></a>
+<span class="sourceLineNo">074</span> /**<a name="line.74"></a>
+<span class="sourceLineNo">075</span> * Constructor<a name="line.75"></a>
+<span class="sourceLineNo">076</span> * @param env MasterProcedureEnv<a name="line.76"></a>
+<span class="sourceLineNo">077</span> * @param tableName the table to operate on<a name="line.77"></a>
+<span class="sourceLineNo">078</span> * @param skipTableStateCheck whether to check table state<a name="line.78"></a>
+<span class="sourceLineNo">079</span> */<a name="line.79"></a>
+<span class="sourceLineNo">080</span> public EnableTableProcedure(final MasterProcedureEnv env, final TableName tableName,<a name="line.80"></a>
+<span class="sourceLineNo">081</span> final boolean skipTableStateCheck, final ProcedurePrepareLatch syncLatch) {<a name="line.81"></a>
+<span class="sourceLineNo">082</span> super(env, syncLatch);<a name="line.82"></a>
+<span class="sourceLineNo">083</span> this.tableName = tableName;<a name="line.83"></a>
+<span class="sourceLineNo">084</span> this.skipTableStateCheck = skipTableStateCheck;<a name="line.84"></a>
+<span class="sourceLineNo">085</span> }<a name="line.85"></a>
+<span class="sourceLineNo">086</span><a name="line.86"></a>
+<span class="sourceLineNo">087</span> @SuppressWarnings("deprecation")<a name="line.87"></a>
+<span class="sourceLineNo">088</span> @Override<a name="line.88"></a>
+<span class="sourceLineNo">089</span> protected Flow executeFromState(final MasterProcedureEnv env, final EnableTableState state)<a name="line.89"></a>
+<span class="sourceLineNo">090</span> throws InterruptedException {<a name="line.90"></a>
+<span class="sourceLineNo">091</span> if (isTraceEnabled()) {<a name="line.91"></a>
+<span class="sourceLineNo">092</span> LOG.trace(this + " execute state=" + state);<a name="line.92"></a>
+<span class="sourceLineNo">093</span> }<a name="line.93"></a>
+<span class="sourceLineNo">094</span><a name="line.94"></a>
+<span class="sourceLineNo">095</span> try {<a name="line.95"></a>
+<span class="sourceLineNo">096</span> switch (state) {<a name="line.96"></a>
+<span class="sourceLineNo">097</span> case ENABLE_TABLE_PREPARE:<a name="line.97"></a>
+<span class="sourceLineNo">098</span> if (prepareEnable(env)) {<a name="line.98"></a>
+<span class="sourceLineNo">099</span> setNextState(EnableTableState.ENABLE_TABLE_PRE_OPERATION);<a name="line.99"></a>
+<span class="sourceLineNo">100</span> } else {<a name="line.100"></a>
+<span class="sourceLineNo">101</span> assert isFailed() : "enable should have an exception here";<a name="line.101"></a>
+<span class="sourceLineNo">102</span> return Flow.NO_MORE_STATE;<a name="line.102"></a>
+<span class="sourceLineNo">103</span> }<a name="line.103"></a>
+<span class="sourceLineNo">104</span> break;<a name="line.104"></a>
+<span class="sourceLineNo">105</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.105"></a>
+<span class="sourceLineNo">106</span> preEnable(env, state);<a name="line.106"></a>
+<span class="sourceLineNo">107</span> setNextState(EnableTableState.ENABLE_TABLE_SET_ENABLING_TABLE_STATE);<a name="line.107"></a>
+<span class="sourceLineNo">108</span> break;<a name="line.108"></a>
+<span class="sourceLineNo">109</span> case ENABLE_TABLE_SET_ENABLING_TABLE_STATE:<a name="line.109"></a>
+<span class="sourceLineNo">110</span> setTableStateToEnabling(env, tableName);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> setNextState(EnableTableState.ENABLE_TABLE_MARK_REGIONS_ONLINE);<a name="line.111"></a>
+<span class="sourceLineNo">112</span> break;<a name="line.112"></a>
+<span class="sourceLineNo">113</span> case ENABLE_TABLE_MARK_REGIONS_ONLINE:<a name="line.113"></a>
+<span class="sourceLineNo">114</span> Connection connection = env.getMasterServices().getConnection();<a name="line.114"></a>
+<span class="sourceLineNo">115</span> // we will need to get the tableDescriptor here to see if there is a change in the replica<a name="line.115"></a>
+<span class="sourceLineNo">116</span> // count<a name="line.116"></a>
+<span class="sourceLineNo">117</span> TableDescriptor hTableDescriptor =<a name="line.117"></a>
+<span class="sourceLineNo">118</span> env.getMasterServices().getTableDescriptors().get(tableName);<a name="line.118"></a>
+<span class="sourceLineNo">119</span><a name="line.119"></a>
+<span class="sourceLineNo">120</span> // Get the replica count<a name="line.120"></a>
+<span class="sourceLineNo">121</span> int regionReplicaCount = hTableDescriptor.getRegionReplication();<a name="line.121"></a>
+<span class="sourceLineNo">122</span><a name="line.122"></a>
+<span class="sourceLineNo">123</span> // Get the regions for the table from the memory<a name="line.123"></a>
+<span class="sourceLineNo">124</span> List<RegionInfo> regionsOfTable =<a name="line.124"></a>
+<span class="sourceLineNo">125</span> env.getAssignmentManager().getRegionStates().getRegionsOfTable(tableName);<a name="line.125"></a>
+<span class="sourceLineNo">126</span><a name="line.126"></a>
+<span class="sourceLineNo">127</span> if (regionReplicaCount > 1) {<a name="line.127"></a>
+<span class="sourceLineNo">128</span> int currentMaxReplica = 0;<a name="line.128"></a>
+<span class="sourceLineNo">129</span> // Check if the regions in memory have replica regions as marked in META table<a name="line.129"></a>
+<span class="sourceLineNo">130</span> for (RegionInfo regionInfo : regionsOfTable) {<a name="line.130"></a>
+<span class="sourceLineNo">131</span> if (regionInfo.getReplicaId() > currentMaxReplica) {<a name="line.131"></a>
+<span class="sourceLineNo">132</span> // Iterating through all the list to identify the highest replicaID region.<a name="line.132"></a>
+<span class="sourceLineNo">133</span> // We can stop after checking with the first set of regions??<a name="line.133"></a>
+<span class="sourceLineNo">134</span> currentMaxReplica = regionInfo.getReplicaId();<a name="line.134"></a>
+<span class="sourceLineNo">135</span> }<a name="line.135"></a>
+<span class="sourceLineNo">136</span> }<a name="line.136"></a>
+<span class="sourceLineNo">137</span><a name="line.137"></a>
+<span class="sourceLineNo">138</span> // read the META table to know the actual number of replicas for the table - if there<a name="line.138"></a>
+<span class="sourceLineNo">139</span> // was a table modification on region replica then this will reflect the new entries also<a name="line.139"></a>
+<span class="sourceLineNo">140</span> int replicasFound =<a name="line.140"></a>
+<span class="sourceLineNo">141</span> getNumberOfReplicasFromMeta(connection, regionReplicaCount, regionsOfTable);<a name="line.141"></a>
+<span class="sourceLineNo">142</span> assert regionReplicaCount - 1 == replicasFound;<a name="line.142"></a>
+<span class="sourceLineNo">143</span> LOG.info(replicasFound + " META entries added for the given regionReplicaCount "<a name="line.143"></a>
+<span class="sourceLineNo">144</span> + regionReplicaCount + " for the table " + tableName.getNameAsString());<a name="line.144"></a>
+<span class="sourceLineNo">145</span> if (currentMaxReplica == (regionReplicaCount - 1)) {<a name="line.145"></a>
+<span class="sourceLineNo">146</span> if (LOG.isDebugEnabled()) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span> LOG.debug("There is no change to the number of region replicas."<a name="line.147"></a>
+<span class="sourceLineNo">148</span> + " Assigning the available regions." + " Current and previous"<a name="line.148"></a>
+<span class="sourceLineNo">149</span> + "replica count is " + regionReplicaCount);<a name="line.149"></a>
+<span class="sourceLineNo">150</span> }<a name="line.150"></a>
+<span class="sourceLineNo">151</span> } else if (currentMaxReplica > (regionReplicaCount - 1)) {<a name="line.151"></a>
+<span class="sourceLineNo">152</span> // we have additional regions as the replica count has been decreased. Delete<a name="line.152"></a>
+<span class="sourceLineNo">153</span> // those regions because already the table is in the unassigned state<a name="line.153"></a>
+<span class="sourceLineNo">154</span> LOG.info("The number of replicas " + (currentMaxReplica + 1)<a name="line.154"></a>
+<span class="sourceLineNo">155</span> + " is more than the region replica count " + regionReplicaCount);<a name="line.155"></a>
+<span class="sourceLineNo">156</span> List<RegionInfo> copyOfRegions = new ArrayList<RegionInfo>(regionsOfTable);<a name="line.156"></a>
+<span class="sourceLineNo">157</span> for (RegionInfo regionInfo : copyOfRegions) {<a name="line.157"></a>
+<span class="sourceLineNo">158</span> if (regionInfo.getReplicaId() > (regionReplicaCount - 1)) {<a name="line.158"></a>
+<span class="sourceLineNo">159</span> // delete the region from the regionStates<a name="line.159"></a>
+<span class="sourceLineNo">160</span> env.getAssignmentManager().getRegionStates().deleteRegion(regionInfo);<a name="line.160"></a>
+<span class="sourceLineNo">161</span> // remove it from the list of regions of the table<a name="line.161"></a>
+<span class="sourceLineNo">162</span> LOG.info("The regioninfo being removed is " + regionInfo + " "<a name="line.162"></a>
+<span class="sourceLineNo">163</span> + regionInfo.getReplicaId());<a name="line.163"></a>
+<span class="sourceLineNo">164</span> regionsOfTable.remove(regionInfo);<a name="line.164"></a>
+<span class="sourceLineNo">165</span> }<a name="line.165"></a>
+<span class="sourceLineNo">166</span> }<a name="line.166"></a>
+<span class="sourceLineNo">167</span> } else {<a name="line.167"></a>
+<span class="sourceLineNo">168</span> // the replicasFound is less than the regionReplication<a name="line.168"></a>
+<span class="sourceLineNo">169</span> LOG.info(<a name="line.169"></a>
+<span class="sourceLineNo">170</span> "The number of replicas has been changed(increased)."<a name="line.170"></a>
+<span class="sourceLineNo">171</span> + " Lets assign the new region replicas. The previous replica count was "<a name="line.171"></a>
+<span class="sourceLineNo">172</span> + (currentMaxReplica + 1) + ". The current replica count is "<a name="line.172"></a>
+<span class="sourceLineNo">173</span> + regionReplicaCount);<a name="line.173"></a>
+<span class="sourceLineNo">174</span> regionsOfTable = RegionReplicaUtil.addReplicas(hTableDescriptor, regionsOfTable,<a name="line.174"></a>
+<span class="sourceLineNo">175</span> currentMaxReplica + 1, regionReplicaCount);<a name="line.175"></a>
+<span class="sourceLineNo">176</span> }<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> // Assign all the table regions. (including region replicas if added)<a name="line.178"></a>
+<span class="sourceLineNo">179</span> addChildProcedure(env.getAssignmentManager().createAssignProcedures(regionsOfTable));<a name="line.179"></a>
+<span class="sourceLineNo">180</span> setNextState(EnableTableState.ENABLE_TABLE_SET_ENABLED_TABLE_STATE);<a name="line.180"></a>
+<span class="sourceLineNo">181</span> break;<a name="line.181"></a>
+<span class="sourceLineNo">182</span> case ENABLE_TABLE_SET_ENABLED_TABLE_STATE:<a name="line.182"></a>
+<span class="sourceLineNo">183</span> setTableStateToEnabled(env, tableName);<a name="line.183"></a>
+<span class="sourceLineNo">184</span> setNextState(EnableTableState.ENABLE_TABLE_POST_OPERATION);<a name="line.184"></a>
+<span class="sourceLineNo">185</span> break;<a name="line.185"></a>
+<span class="sourceLineNo">186</span> case ENABLE_TABLE_POST_OPERATION:<a name="line.186"></a>
+<span class="sourceLineNo">187</span> postEnable(env, state);<a name="line.187"></a>
+<span class="sourceLineNo">188</span> return Flow.NO_MORE_STATE;<a name="line.188"></a>
+<span class="sourceLineNo">189</span> default:<a name="line.189"></a>
+<span class="sourceLineNo">190</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> }<a name="line.191"></a>
+<span class="sourceLineNo">192</span> } catch (IOException e) {<a name="line.192"></a>
+<span class="sourceLineNo">193</span> if (isRollbackSupported(state)) {<a name="line.193"></a>
+<span class="sourceLineNo">194</span> setFailure("master-enable-table", e);<a name="line.194"></a>
+<span class="sourceLineNo">195</span> } else {<a name="line.195"></a>
+<span class="sourceLineNo">196</span> LOG.warn("Retriable error trying to enable table=" + tableName +<a name="line.196"></a>
+<span class="sourceLineNo">197</span> " (in state=" + state + ")", e);<a name="line.197"></a>
+<span class="sourceLineNo">198</span> }<a name="line.198"></a>
+<span class="sourceLineNo">199</span> }<a name="line.199"></a>
+<span class="sourceLineNo">200</span> return Flow.HAS_MORE_STATE;<a name="line.200"></a>
+<span class="sourceLineNo">201</span> }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span> private int getNumberOfReplicasFromMeta(Connection connection, int regionReplicaCount,<a name="line.203"></a>
+<span class="sourceLineNo">204</span> List<RegionInfo> regionsOfTable) throws IOException {<a name="line.204"></a>
+<span class="sourceLineNo">205</span> Result r = getRegionFromMeta(connection, regionsOfTable);<a name="line.205"></a>
+<span class="sourceLineNo">206</span> int replicasFound = 0;<a name="line.206"></a>
+<span class="sourceLineNo">207</span> for (int i = 1; i < regionReplicaCount; i++) {<a name="line.207"></a>
+<span class="sourceLineNo">208</span> // Since we have already added the entries to the META we will be getting only that here<a name="line.208"></a>
+<span class="sourceLineNo">209</span> List<Cell> columnCells =<a name="line.209"></a>
+<span class="sourceLineNo">210</span> r.getColumnCells(HConstants.CATALOG_FAMILY, MetaTableAccessor.getServerColumn(i));<a name="line.210"></a>
+<span class="sourceLineNo">211</span> if (!columnCells.isEmpty()) {<a name="line.211"></a>
+<span class="sourceLineNo">212</span> replicasFound++;<a name="line.212"></a>
+<span class="sourceLineNo">213</span> }<a name="line.213"></a>
+<span class="sourceLineNo">214</span> }<a name="line.214"></a>
+<span class="sourceLineNo">215</span> return replicasFound;<a name="line.215"></a>
+<span class="sourceLineNo">216</span> }<a name="line.216"></a>
+<span class="sourceLineNo">217</span><a name="line.217"></a>
+<span class="sourceLineNo">218</span> private Result getRegionFromMeta(Connection connection, List<RegionInfo> regionsOfTable)<a name="line.218"></a>
+<span class="sourceLineNo">219</span> throws IOException {<a name="line.219"></a>
+<span class="sourceLineNo">220</span> byte[] metaKeyForRegion = MetaTableAccessor.getMetaKeyForRegion(regionsOfTable.get(0));<a name="line.220"></a>
+<span class="sourceLineNo">221</span> Get get = new Get(metaKeyForRegion);<a name="line.221"></a>
+<span class="sourceLineNo">222</span> get.addFamily(HConstants.CATALOG_FAMILY);<a name="line.222"></a>
+<span class="sourceLineNo">223</span> Table metaTable = MetaTableAccessor.getMetaHTable(connection);<a name="line.223"></a>
+<span class="sourceLineNo">224</span> Result r = metaTable.get(get);<a name="line.224"></a>
+<span class="sourceLineNo">225</span> return r;<a name="line.225"></a>
+<span class="sourceLineNo">226</span> }<a name="line.226"></a>
+<span class="sourceLineNo">227</span><a name="line.227"></a>
+<span class="sourceLineNo">228</span> @Override<a name="line.228"></a>
+<span class="sourceLineNo">229</span> protected void rollbackState(final MasterProcedureEnv env, final EnableTableState state)<a name="line.229"></a>
+<span class="sourceLineNo">230</span> throws IOException {<a name="line.230"></a>
+<span class="sourceLineNo">231</span> // nothing to rollback, prepare-disable is just table-state checks.<a name="line.231"></a>
+<span class="sourceLineNo">232</span> // We can fail if the table does not exist or is not disabled.<a name="line.232"></a>
+<span class="sourceLineNo">233</span> switch (state) {<a name="line.233"></a>
+<span class="sourceLineNo">234</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.234"></a>
+<span class="sourceLineNo">235</span> return;<a name="line.235"></a>
+<span class="sourceLineNo">236</span> case ENABLE_TABLE_PREPARE:<a name="line.236"></a>
+<span class="sourceLineNo">237</span> releaseSyncLatch();<a name="line.237"></a>
+<span class="sourceLineNo">238</span> return;<a name="line.238"></a>
+<span class="sourceLineNo">239</span> default:<a name="line.239"></a>
+<span class="sourceLineNo">240</span> break;<a name="line.240"></a>
+<span class="sourceLineNo">241</span> }<a name="line.241"></a>
+<span class="sourceLineNo">242</span><a name="line.242"></a>
+<span class="sourceLineNo">243</span> // The delete doesn't have a rollback. The execution will succeed, at some point.<a name="line.243"></a>
+<span class="sourceLineNo">244</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.244"></a>
<span class="sourceLineNo">245</span> }<a name="line.245"></a>
<span class="sourceLineNo">246</span><a name="line.246"></a>
-<span class="sourceLineNo">247</span> /**<a name="line.247"></a>
-<span class="sourceLineNo">248</span> * Action before enabling table.<a name="line.248"></a>
-<span class="sourceLineNo">249</span> * @param env MasterProcedureEnv<a name="line.249"></a>
-<span class="sourceLineNo">250</span> * @param state the procedure state<a name="line.250"></a>
-<span class="sourceLineNo">251</span> * @throws IOException<a name="line.251"></a>
-<span class="sourceLineNo">252</span> * @throws InterruptedException<a name="line.252"></a>
-<span class="sourceLineNo">253</span> */<a name="line.253"></a>
-<span class="sourceLineNo">254</span> private void preEnable(final MasterProcedureEnv env, final EnableTableState state)<a name="line.254"></a>
-<span class="sourceLineNo">255</span> throws IOException, InterruptedException {<a name="line.255"></a>
-<span class="sourceLineNo">256</span> runCoprocessorAction(env, state);<a name="line.256"></a>
-<span class="sourceLineNo">257</span> }<a name="line.257"></a>
-<span class="sourceLineNo">258</span><a name="line.258"></a>
-<span class="sourceLineNo">259</span> /**<a name="line.259"></a>
-<span class="sourceLineNo">260</span> * Mark table state to Enabling<a name="line.260"></a>
-<span class="sourceLineNo">261</span> * @param env MasterProcedureEnv<a name="line.261"></a>
-<span class="sourceLineNo">262</span> * @param tableName the target table<a name="line.262"></a>
-<span class="sourceLineNo">263</span> * @throws IOException<a name="line.263"></a>
-<span class="sourceLineNo">264</span> */<a name="line.264"></a>
-<span class="sourceLineNo">265</span> protected static void setTableStateToEnabling(<a name="line.265"></a>
-<span class="sourceLineNo">266</span> final MasterProcedureEnv env,<a name="line.266"></a>
-<span class="sourceLineNo">267</span> final TableName tableName) throws IOException {<a name="line.267"></a>
-<span class="sourceLineNo">268</span> // Set table disabling flag up in zk.<a name="line.268"></a>
-<span class="sourceLineNo">269</span> LOG.info("Attempting to enable the table " + tableName);<a name="line.269"></a>
-<span class="sourceLineNo">270</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.270"></a>
-<span class="sourceLineNo">271</span> tableName,<a name="line.271"></a>
-<span class="sourceLineNo">272</span> TableState.State.ENABLING);<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span><a name="line.274"></a>
-<span class="sourceLineNo">275</span> /**<a name="line.275"></a>
-<span class="sourceLineNo">276</span> * Mark table state to Enabled<a name="line.276"></a>
-<span class="sourceLineNo">277</span> * @param env MasterProcedureEnv<a name="line.277"></a>
-<span class="sourceLineNo">278</span> * @throws IOException<a name="line.278"></a>
-<span class="sourceLineNo">279</span> */<a name="line.279"></a>
-<span class="sourceLineNo">280</span> protected static void setTableStateToEnabled(<a name="line.280"></a>
-<span class="sourceLineNo">281</span> final MasterProcedureEnv env,<a name="line.281"></a>
-<span class="sourceLineNo">282</span> final TableName tableName) throws IOException {<a name="line.282"></a>
-<span class="sourceLineNo">283</span> // Flip the table to Enabled<a name="line.283"></a>
-<span class="sourceLineNo">284</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.284"></a>
-<span class="sourceLineNo">285</span> tableName,<a name="line.285"></a>
-<span class="sourceLineNo">286</span> TableState.State.ENABLED);<a name="line.286"></a>
-<span class="sourceLineNo">287</span> LOG.info("Table '" + tableName + "' was successfully enabled.");<a name="line.287"></a>
-<span class="sourceLineNo">288</span> }<a name="line.288"></a>
-<span class="sourceLineNo">289</span><a name="line.289"></a>
-<span class="sourceLineNo">290</span> /**<a name="line.290"></a>
-<span class="sourceLineNo">291</span> * Action after enabling table.<a name="line.291"></a>
-<span class="sourceLineNo">292</span> * @param env MasterProcedureEnv<a name="line.292"></a>
-<span class="sourceLineNo">293</span> * @param state the procedure state<a name="line.293"></a>
-<span class="sourceLineNo">294</span> * @throws IOException<a name="line.294"></a>
-<span class="sourceLineNo">295</span> * @throws InterruptedException<a name="line.295"></a>
-<span class="sourceLineNo">296</span> */<a name="line.296"></a>
-<span class="sourceLineNo">297</span> private void postEnable(final MasterProcedureEnv env, final EnableTableState state)<a name="line.297"></a>
-<span class="sourceLineNo">298</span> throws IOException, InterruptedException {<a name="line.298"></a>
-<span class="sourceLineNo">299</span> runCoprocessorAction(env, state);<a name="line.299"></a>
-<span class="sourceLineNo">300</span> }<a name="line.300"></a>
-<span class="sourceLineNo">301</span><a name="line.301"></a>
-<span class="sourceLineNo">302</span> /**<a name="line.302"></a>
-<span class="sourceLineNo">303</span> * The procedure could be restarted from a different machine. If the variable is null, we need to<a name="line.303"></a>
-<span class="sourceLineNo">304</span> * retrieve it.<a name="line.304"></a>
-<span class="sourceLineNo">305</span> * @return traceEnabled<a name="line.305"></a>
-<span class="sourceLineNo">306</span> */<a name="line.306"></a>
-<span class="sourceLineNo">307</span> private Boolean isTraceEnabled() {<a name="line.307"></a>
-<span class="sourceLineNo">308</span> if (traceEnabled == null) {<a name="line.308"></a>
-<span class="sourceLineNo">309</span> traceEnabled = LOG.isTraceEnabled();<a name="line.309"></a>
-<span class="sourceLineNo">310</span> }<a name="line.310"></a>
-<span class="sourceLineNo">311</span> return traceEnabled;<a name="line.311"></a>
-<span class="sourceLineNo">312</span> }<a name="line.312"></a>
-<span class="sourceLineNo">313</span><a name="line.313"></a>
-<span class="sourceLineNo">314</span> /**<a name="line.314"></a>
-<span class="sourceLineNo">315</span> * Coprocessor Action.<a name="line.315"></a>
-<span class="sourceLineNo">316</span> * @param env MasterProcedureEnv<a name="line.316"></a>
-<span class="sourceLineNo">317</span> * @param state the procedure state<a name="line.317"></a>
-<span class="sourceLineNo">318</span> * @throws IOException<a name="line.318"></a>
-<span class="sourceLineNo">319</span> * @throws InterruptedException<a name="line.319"></a>
-<span class="sourceLineNo">320</span> */<a name="line.320"></a>
-<span class="sourceLineNo">321</span> private void runCoprocessorAction(final MasterProcedureEnv env, final EnableTableState state)<a name="line.321"></a>
-<span class="sourceLineNo">322</span> throws IOException, InterruptedException {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.323"></a>
-<span class="sourceLineNo">324</span> if (cpHost != null) {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> switch (state) {<a name="line.325"></a>
-<span class="sourceLineNo">326</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.326"></a>
-<span class="sourceLineNo">327</span> cpHost.preEnableTableAction(getTableName(), getUser());<a name="line.327"></a>
-<span class="sourceLineNo">328</span> break;<a name="line.328"></a>
-<span class="sourceLineNo">329</span> case ENABLE_TABLE_POST_OPERATION:<a name="line.329"></a>
-<span class="sourceLineNo">330</span> cpHost.postCompletedEnableTableAction(getTableName(), getUser());<a name="line.330"></a>
-<span class="sourceLineNo">331</span> break;<a name="line.331"></a>
-<span class="sourceLineNo">332</span> default:<a name="line.332"></a>
-<span class="sourceLineNo">333</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.333"></a>
-<span class="sourceLineNo">334</span> }<a name="line.334"></a>
-<span class="sourceLineNo">335</span> }<a name="line.335"></a>
-<span class="sourceLineNo">336</span> }<a name="line.336"></a>
-<span class="sourceLineNo">337</span>}<a name="line.337"></a>
+<span class="sourceLineNo">247</span> @Override<a name="line.247"></a>
+<span class="sourceLineNo">248</span> protected boolean isRollbackSupported(final EnableTableState state) {<a name="line.248"></a>
+<span class="sourceLineNo">249</span> switch (state) {<a name="line.249"></a>
+<span class="sourceLineNo">250</span> case ENABLE_TABLE_PREPARE:<a name="line.250"></a>
+<span class="sourceLineNo">251</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.251"></a>
+<span class="sourceLineNo">252</span> return true;<a name="line.252"></a>
+<span class="sourceLineNo">253</span> default:<a name="line.253"></a>
+<span class="sourceLineNo">254</span> return false;<a name="line.254"></a>
+<span class="sourceLineNo">255</span> }<a name="line.255"></a>
+<span class="sourceLineNo">256</span> }<a name="line.256"></a>
+<span class="sourceLineNo">257</span><a name="line.257"></a>
+<span class="sourceLineNo">258</span> @Override<a name="line.258"></a>
+<span class="sourceLineNo">259</span> protected EnableTableState getState(final int stateId) {<a name="line.259"></a>
+<span class="sourceLineNo">260</span> return EnableTableState.valueOf(stateId);<a name="line.260"></a>
+<span class="sourceLineNo">261</span> }<a name="line.261"></a>
+<span class="sourceLineNo">262</span><a name="line.262"></a>
+<span class="sourceLineNo">263</span> @Override<a name="line.263"></a>
+<span class="sourceLineNo">264</span> protected int getStateId(final EnableTableState state) {<a name="line.264"></a>
+<span class="sourceLineNo">265</span> return state.getNumber();<a name="line.265"></a>
+<span class="sourceLineNo">266</span> }<a name="line.266"></a>
+<span class="sourceLineNo">267</span><a name="line.267"></a>
+<span class="sourceLineNo">268</span> @Override<a name="line.268"></a>
+<span class="sourceLineNo">269</span> protected EnableTableState getInitialState() {<a name="line.269"></a>
+<span class="sourceLineNo">270</span> return EnableTableState.ENABLE_TABLE_PREPARE;<a name="line.270"></a>
+<span class="sourceLineNo">271</span> }<a name="line.271"></a>
+<span class="sourceLineNo">272</span><a name="line.272"></a>
+<span class="sourceLineNo">273</span> @Override<a name="line.273"></a>
+<span class="sourceLineNo">274</span> protected void serializeStateData(ProcedureStateSerializer serializer)<a name="line.274"></a>
+<span class="sourceLineNo">275</span> throws IOException {<a name="line.275"></a>
+<span class="sourceLineNo">276</span> super.serializeStateData(serializer);<a name="line.276"></a>
+<span class="sourceLineNo">277</span><a name="line.277"></a>
+<span class="sourceLineNo">278</span> MasterProcedureProtos.EnableTableStateData.Builder enableTableMsg =<a name="line.278"></a>
+<span class="sourceLineNo">279</span> MasterProcedureProtos.EnableTableStateData.newBuilder()<a name="line.279"></a>
+<span class="sourceLineNo">280</span> .setUserInfo(MasterProcedureUtil.toProtoUserInfo(getUser()))<a name="line.280"></a>
+<span class="sourceLineNo">281</span> .setTableName(ProtobufUtil.toProtoTableName(tableName))<a name="line.281"></a>
+<span class="sourceLineNo">282</span> .setSkipTableStateCheck(skipTableStateCheck);<a name="line.282"></a>
+<span class="sourceLineNo">283</span><a name="line.283"></a>
+<span class="sourceLineNo">284</span> serializer.serialize(enableTableMsg.build());<a name="line.284"></a>
+<span class="sourceLineNo">285</span> }<a name="line.285"></a>
+<span class="sourceLineNo">286</span><a name="line.286"></a>
+<span class="sourceLineNo">287</span> @Override<a name="line.287"></a>
+<span class="sourceLineNo">288</span> protected void deserializeStateData(ProcedureStateSerializer serializer)<a name="line.288"></a>
+<span class="sourceLineNo">289</span> throws IOException {<a name="line.289"></a>
+<span class="sourceLineNo">290</span> super.deserializeStateData(serializer);<a name="line.290"></a>
+<span class="sourceLineNo">291</span><a name="line.291"></a>
+<span class="sourceLineNo">292</span> MasterProcedureProtos.EnableTableStateData enableTableMsg =<a name="line.292"></a>
+<span class="sourceLineNo">293</span> serializer.deserialize(MasterProcedureProtos.EnableTableStateData.class);<a name="line.293"></a>
+<span class="sourceLineNo">294</span> setUser(MasterProcedureUtil.toUserInfo(enableTableMsg.getUserInfo()));<a name="line.294"></a>
+<span class="sourceLineNo">295</span> tableName = ProtobufUtil.toTableName(enableTableMsg.getTableName());<a name="line.295"></a>
+<span class="sourceLineNo">296</span> skipTableStateCheck = enableTableMsg.getSkipTableStateCheck();<a name="line.296"></a>
+<span class="sourceLineNo">297</span> }<a name="line.297"></a>
+<span class="sourceLineNo">298</span><a name="line.298"></a>
+<span class="sourceLineNo">299</span> @Override<a name="line.299"></a>
+<span class="sourceLineNo">300</span> public TableName getTableName() {<a name="line.300"></a>
+<span class="sourceLineNo">301</span> return tableName;<a name="line.301"></a>
+<span class="sourceLineNo">302</span> }<a name="line.302"></a>
+<span class="sourceLineNo">303</span><a name="line.303"></a>
+<span class="sourceLineNo">304</span> @Override<a name="line.304"></a>
+<span class="sourceLineNo">305</span> public TableOperationType getTableOperationType() {<a name="line.305"></a>
+<span class="sourceLineNo">306</span> return TableOperationType.ENABLE;<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span><a name="line.309"></a>
+<span class="sourceLineNo">310</span> /**<a name="line.310"></a>
+<span class="sourceLineNo">311</span> * Action before any real action of enabling table. Set the exception in the procedure instead<a name="line.311"></a>
+<span class="sourceLineNo">312</span> * of throwing it. This approach is to deal with backward compatible with 1.0.<a name="line.312"></a>
+<span class="sourceLineNo">313</span> * @param env MasterProcedureEnv<a name="line.313"></a>
+<span class="sourceLineNo">314</span> * @return whether the table passes the necessary checks<a name="line.314"></a>
+<span class="sourceLineNo">315</span> * @throws IOException<a name="line.315"></a>
+<span class="sourceLineNo">316</span> */<a name="line.316"></a>
+<span class="sourceLineNo">317</span> private boolean prepareEnable(final MasterProcedureEnv env) throws IOException {<a name="line.317"></a>
+<span class="sourceLineNo">318</span> boolean canTableBeEnabled = true;<a name="line.318"></a>
+<span class="sourceLineNo">319</span><a name="line.319"></a>
+<span class="sourceLineNo">320</span> // Check whether table exists<a name="line.320"></a>
+<span class="sourceLineNo">321</span> if (!MetaTableAccessor.tableExists(env.getMasterServices().getConnection(), tableName)) {<a name="line.321"></a>
+<span class="sourceLineNo">322</span> setFailure("master-enable-table", new TableNotFoundException(tableName));<a name="line.322"></a>
+<span class="sourceLineNo">323</span> canTableBeEnabled = false;<a name="line.323"></a>
+<span class="sourceLineNo">324</span> } else if (!skipTableStateCheck) {<a name="line.324"></a>
+<span class="sourceLineNo">325</span> // There could be multiple client requests trying to disable or enable<a name="line.325"></a>
+<span class="sourceLineNo">326</span> // the table at the same time. Ensure only the first request is honored<a name="line.326"></a>
+<span class="sourceLineNo">327</span> // After that, no other requests can be accepted until the table reaches<a name="line.327"></a>
+<span class="sourceLineNo">328</span> // DISABLED or ENABLED.<a name="line.328"></a>
+<span class="sourceLineNo">329</span> //<a name="line.329"></a>
+<span class="sourceLineNo">330</span> // Note: in 1.0 release, we called TableStateManager.setTableStateIfInStates() to set<a name="line.330"></a>
+<span class="sourceLineNo">331</span> // the state to ENABLING from DISABLED. The implementation was done before table lock<a name="line.331"></a>
+<span class="sourceLineNo">332</span> // was implemented. With table lock, there is no need to set the state here (it will<a name="line.332"></a>
+<span class="sourceLineNo">333</span> // set the state later on). A quick state check should be enough for us to move forward.<a name="line.333"></a>
+<span class="sourceLineNo">334</span> TableStateManager tsm = env.getMasterServices().getTableStateManager();<a name="line.334"></a>
+<span class="sourceLineNo">335</span> TableState.State state = tsm.getTableState(tableName);<a name="line.335"></a>
+<span class="sourceLineNo">336</span> if(!state.equals(TableState.State.DISABLED)){<a name="line.336"></a>
+<span class="sourceLineNo">337</span> LOG.info("Table " + tableName + " isn't disabled;is "+state.name()+"; skipping enable");<a name="line.337"></a>
+<span class="sourceLineNo">338</span> setFailure("master-enable-table", new TableNotDisabledException(<a name="line.338"></a>
+<span class="sourceLineNo">339</span> this.tableName+" state is "+state.name()));<a name="line.339"></a>
+<span class="sourceLineNo">340</span> canTableBeEnabled = false;<a name="line.340"></a>
+<span class="sourceLineNo">341</span> }<a name="line.341"></a>
+<span class="sourceLineNo">342</span> }<a name="line.342"></a>
+<span class="sourceLineNo">343</span><a name="line.343"></a>
+<span class="sourceLineNo">344</span> // We are done the check. Future actions in this procedure could be done asynchronously.<a name="line.344"></a>
+<span class="sourceLineNo">345</span> releaseSyncLatch();<a name="line.345"></a>
+<span class="sourceLineNo">346</span><a name="line.346"></a>
+<span class="sourceLineNo">347</span> return canTableBeEnabled;<a name="line.347"></a>
+<span class="sourceLineNo">348</span> }<a name="line.348"></a>
+<span class="sourceLineNo">349</span><a name="line.349"></a>
+<span class="sourceLineNo">350</span> /**<a name="line.350"></a>
+<span class="sourceLineNo">351</span> * Action before enabling table.<a name="line.351"></a>
+<span class="sourceLineNo">352</span> * @param env MasterProcedureEnv<a name="line.352"></a>
+<span class="sourceLineNo">353</span> * @param state the procedure state<a name="line.353"></a>
+<span class="sourceLineNo">354</span> * @throws IOException<a name="line.354"></a>
+<span class="sourceLineNo">355</span> * @throws InterruptedException<a name="line.355"></a>
+<span class="sourceLineNo">356</span> */<a name="line.356"></a>
+<span class="sourceLineNo">357</span> private void preEnable(final MasterProcedureEnv env, final EnableTableState state)<a name="line.357"></a>
+<span class="sourceLineNo">358</span> throws IOException, InterruptedException {<a name="line.358"></a>
+<span class="sourceLineNo">359</span> runCoprocessorAction(env, state);<a name="line.359"></a>
+<span class="sourceLineNo">360</span> }<a name="line.360"></a>
+<span class="sourceLineNo">361</span><a name="line.361"></a>
+<span class="sourceLineNo">362</span> /**<a name="line.362"></a>
+<span class="sourceLineNo">363</span> * Mark table state to Enabling<a name="line.363"></a>
+<span class="sourceLineNo">364</span> * @param env MasterProcedureEnv<a name="line.364"></a>
+<span class="sourceLineNo">365</span> * @param tableName the target table<a name="line.365"></a>
+<span class="sourceLineNo">366</span> * @throws IOException<a name="line.366"></a>
+<span class="sourceLineNo">367</span> */<a name="line.367"></a>
+<span class="sourceLineNo">368</span> protected static void setTableStateToEnabling(<a name="line.368"></a>
+<span class="sourceLineNo">369</span> final MasterProcedureEnv env,<a name="line.369"></a>
+<span class="sourceLineNo">370</span> final TableName tableName) throws IOException {<a name="line.370"></a>
+<span class="sourceLineNo">371</span> // Set table disabling flag up in zk.<a name="line.371"></a>
+<span class="sourceLineNo">372</span> LOG.info("Attempting to enable the table " + tableName);<a name="line.372"></a>
+<span class="sourceLineNo">373</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.373"></a>
+<span class="sourceLineNo">374</span> tableName,<a name="line.374"></a>
+<span class="sourceLineNo">375</span> TableState.State.ENABLING);<a name="line.375"></a>
+<span class="sourceLineNo">376</span> }<a name="line.376"></a>
+<span class="sourceLineNo">377</span><a name="line.377"></a>
+<span class="sourceLineNo">378</span> /**<a name="line.378"></a>
+<span class="sourceLineNo">379</span> * Mark table state to Enabled<a name="line.379"></a>
+<span class="sourceLineNo">380</span> * @param env MasterProcedureEnv<a name="line.380"></a>
+<span class="sourceLineNo">381</span> * @throws IOException<a name="line.381"></a>
+<span class="sourceLineNo">382</span> */<a name="line.382"></a>
+<span class="sourceLineNo">383</span> protected static void setTableStateToEnabled(<a name="line.383"></a>
+<span class="sourceLineNo">384</span> final MasterProcedureEnv env,<a name="line.384"></a>
+<span class="sourceLineNo">385</span> final TableName tableName) throws IOException {<a name="line.385"></a>
+<span class="sourceLineNo">386</span> // Flip the table to Enabled<a name="line.386"></a>
+<span class="sourceLineNo">387</span> env.getMasterServices().getTableStateManager().setTableState(<a name="line.387"></a>
+<span class="sourceLineNo">388</span> tableName,<a name="line.388"></a>
+<span class="sourceLineNo">389</span> TableState.State.ENABLED);<a name="line.389"></a>
+<span class="sourceLineNo">390</span> LOG.info("Table '" + tableName + "' was successfully enabled.");<a name="line.390"></a>
+<span class="sourceLineNo">391</span> }<a name="line.391"></a>
+<span class="sourceLineNo">392</span><a name="line.392"></a>
+<span class="sourceLineNo">393</span> /**<a name="line.393"></a>
+<span class="sourceLineNo">394</span> * Action after enabling table.<a name="line.394"></a>
+<span class="sourceLineNo">395</span> * @param env MasterProcedureEnv<a name="line.395"></a>
+<span class="sourceLineNo">396</span> * @param state the procedure state<a name="line.396"></a>
+<span class="sourceLineNo">397</span> * @throws IOException<a name="line.397"></a>
+<span class="sourceLineNo">398</span> * @throws InterruptedException<a name="line.398"></a>
+<span class="sourceLineNo">399</span> */<a name="line.399"></a>
+<span class="sourceLineNo">400</span> private void postEnable(final MasterProcedureEnv env, final EnableTableState state)<a name="line.400"></a>
+<span class="sourceLineNo">401</span> throws IOException, InterruptedException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> runCoprocessorAction(env, state);<a name="line.402"></a>
+<span class="sourceLineNo">403</span> }<a name="line.403"></a>
+<span class="sourceLineNo">404</span><a name="line.404"></a>
+<span class="sourceLineNo">405</span> /**<a name="line.405"></a>
+<span class="sourceLineNo">406</span> * The procedure could be restarted from a different machine. If the variable is null, we need to<a name="line.406"></a>
+<span class="sourceLineNo">407</span> * retrieve it.<a name="line.407"></a>
+<span class="sourceLineNo">408</span> * @return traceEnabled<a name="line.408"></a>
+<span class="sourceLineNo">409</span> */<a name="line.409"></a>
+<span class="sourceLineNo">410</span> private Boolean isTraceEnabled() {<a name="line.410"></a>
+<span class="sourceLineNo">411</span> if (traceEnabled == null) {<a name="line.411"></a>
+<span class="sourceLineNo">412</span> traceEnabled = LOG.isTraceEnabled();<a name="line.412"></a>
+<span class="sourceLineNo">413</span> }<a name="line.413"></a>
+<span class="sourceLineNo">414</span> return traceEnabled;<a name="line.414"></a>
+<span class="sourceLineNo">415</span> }<a name="line.415"></a>
+<span class="sourceLineNo">416</span><a name="line.416"></a>
+<span class="sourceLineNo">417</span> /**<a name="line.417"></a>
+<span class="sourceLineNo">418</span> * Coprocessor Action.<a name="line.418"></a>
+<span class="sourceLineNo">419</span> * @param env MasterProcedureEnv<a name="line.419"></a>
+<span class="sourceLineNo">420</span> * @param state the procedure state<a name="line.420"></a>
+<span class="sourceLineNo">421</span> * @throws IOException<a name="line.421"></a>
+<span class="sourceLineNo">422</span> * @throws InterruptedException<a name="line.422"></a>
+<span class="sourceLineNo">423</span> */<a name="line.423"></a>
+<span class="sourceLineNo">424</span> private void runCoprocessorAction(final MasterProcedureEnv env, final EnableTableState state)<a name="line.424"></a>
+<span class="sourceLineNo">425</span> throws IOException, InterruptedException {<a name="line.425"></a>
+<span class="sourceLineNo">426</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.426"></a>
+<span class="sourceLineNo">427</span> if (cpHost != null) {<a name="line.427"></a>
+<span class="sourceLineNo">428</span> switch (state) {<a name="line.428"></a>
+<span class="sourceLineNo">429</span> case ENABLE_TABLE_PRE_OPERATION:<a name="line.429"></a>
+<span class="sourceLineNo">430</span> cpHost.preEnableTableAction(getTableName(), getUser());<a name="line.430"></a>
+<span class="sourceLineNo">431</span> break;<a name="line.431"></a>
+<span class="sourceLineNo">432</span> case ENABLE_TABLE_POST_OPERATION:<a name="line.432"></a>
+<span class="sourceLineNo">433</span> cpHost.postCompletedEnableTableAction(getTableName(), getUser());<a name="line.433"></a>
+<span class="sourceLineNo">434</span> break;<a name="line.434"></a>
+<span class="sourceLineNo">435</span> default:<a name="line.435"></a>
+<span class="sourceLineNo">436</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.436"></a>
+<span class="sourceLineNo">437</span> }<a name="line.437"></a>
+<span class="sourceLineNo">438</span> }<a name="line.438"></a>
+<span class="sourceLineNo">439</span> }<a name="line.439"></a>
+<span class="sourceLineNo">440</span>}<a name="line.440"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/73598816/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.html
index ea01398..51c2a4d 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.html
@@ -367,69 +367,83 @@
<span class="sourceLineNo">359</span> connection);<a name="line.359"></a>
<span class="sourceLineNo">360</span> }<a name="line.360"></a>
<span class="sourceLineNo">361</span> }<a name="line.361"></a>
-<span class="sourceLineNo">362</span><a name="line.362"></a>
-<span class="sourceLineNo">363</span> // Setup replication for region replicas if needed<a name="line.363"></a>
-<span class="sourceLineNo">364</span> if (newReplicaCount > 1 && oldReplicaCount <= 1) {<a name="line.364"></a>
-<span class="sourceLineNo">365</span> ServerRegionReplicaUtil.setupRegionReplicaReplication(env.getMasterConfiguration());<a name="line.365"></a>
-<span class="sourceLineNo">366</span> }<a name="line.366"></a>
-<span class="sourceLineNo">367</span> }<a name="line.367"></a>
-<span class="sourceLineNo">368</span><a name="line.368"></a>
-<span class="sourceLineNo">369</span> /**<a name="line.369"></a>
-<span class="sourceLineNo">370</span> * Action after modifying table.<a name="line.370"></a>
-<span class="sourceLineNo">371</span> * @param env MasterProcedureEnv<a name="line.371"></a>
-<span class="sourceLineNo">372</span> * @param state the procedure state<a name="line.372"></a>
-<span class="sourceLineNo">373</span> * @throws IOException<a name="line.373"></a>
-<span class="sourceLineNo">374</span> * @throws InterruptedException<a name="line.374"></a>
-<span class="sourceLineNo">375</span> */<a name="line.375"></a>
-<span class="sourceLineNo">376</span> private void postModify(final MasterProcedureEnv env, final ModifyTableState state)<a name="line.376"></a>
-<span class="sourceLineNo">377</span> throws IOException, InterruptedException {<a name="line.377"></a>
-<span class="sourceLineNo">378</span> runCoprocessorAction(env, state);<a name="line.378"></a>
-<span class="sourceLineNo">379</span> }<a name="line.379"></a>
-<span class="sourceLineNo">380</span><a name="line.380"></a>
-<span class="sourceLineNo">381</span> /**<a name="line.381"></a>
-<span class="sourceLineNo">382</span> * The procedure could be restarted from a different machine. If the variable is null, we need to<a name="line.382"></a>
-<span class="sourceLineNo">383</span> * retrieve it.<a name="line.383"></a>
-<span class="sourceLineNo">384</span> * @return traceEnabled whether the trace is enabled<a name="line.384"></a>
-<span class="sourceLineNo">385</span> */<a name="line.385"></a>
-<span class="sourceLineNo">386</span> private Boolean isTraceEnabled() {<a name="line.386"></a>
-<span class="sourceLineNo">387</span> if (traceEnabled == null) {<a name="line.387"></a>
-<span class="sourceLineNo">388</span> traceEnabled = LOG.isTraceEnabled();<a name="line.388"></a>
-<span class="sourceLineNo">389</span> }<a name="line.389"></a>
-<span class="sourceLineNo">390</span> return traceEnabled;<a name="line.390"></a>
-<span class="sourceLineNo">391</span> }<a name="line.391"></a>
-<span class="sourceLineNo">392</span><a name="line.392"></a>
-<span class="sourceLineNo">393</span> /**<a name="line.393"></a>
-<span class="sourceLineNo">394</span> * Coprocessor Action.<a name="line.394"></a>
-<span class="sourceLineNo">395</span> * @param env MasterProcedureEnv<a name="line.395"></a>
-<span class="sourceLineNo">396</span> * @param state the procedure state<a name="line.396"></a>
-<span class="sourceLineNo">397</span> * @throws IOException<a name="line.397"></a>
-<span class="sourceLineNo">398</span> * @throws InterruptedException<a name="line.398"></a>
+<span class="sourceLineNo">362</span> if (newReplicaCount > oldReplicaCount) {<a name="line.362"></a>
+<span class="sourceLineNo">363</span> Connection connection = env.getMasterServices().getConnection();<a name="line.363"></a>
+<span class="sourceLineNo">364</span> // Get the existing table regions<a name="line.364"></a>
+<span class="sourceLineNo">365</span> List<RegionInfo> existingTableRegions =<a name="line.365"></a>
+<span class="sourceLineNo">366</span> MetaTableAccessor.getTableRegions(connection, getTableName());<a name="line.366"></a>
+<span class="sourceLineNo">367</span> // add all the new entries to the meta table<a name="line.367"></a>
+<span class="sourceLineNo">368</span> addRegionsToMeta(env, newTableDescriptor, existingTableRegions);<a name="line.368"></a>
+<span class="sourceLineNo">369</span> if (oldReplicaCount <= 1) {<a name="line.369"></a>
+<span class="sourceLineNo">370</span> // The table has been newly enabled for replica. So check if we need to setup<a name="line.370"></a>
+<span class="sourceLineNo">371</span> // region replication<a name="line.371"></a>
+<span class="sourceLineNo">372</span> ServerRegionReplicaUtil.setupRegionReplicaReplication(env.getMasterConfiguration());<a name="line.372"></a>
+<span class="sourceLineNo">373</span> }<a name="line.373"></a>
+<span class="sourceLineNo">374</span> }<a name="line.374"></a>
+<span class="sourceLineNo">375</span> }<a name="line.375"></a>
+<span class="sourceLineNo">376</span><a name="line.376"></a>
+<span class="sourceLineNo">377</span> private static void addRegionsToMeta(final MasterProcedureEnv env,<a name="line.377"></a>
+<span class="sourceLineNo">378</span> final TableDescriptor tableDescriptor, final List<RegionInfo> regionInfos)<a name="line.378"></a>
+<span class="sourceLineNo">379</span> throws IOException {<a name="line.379"></a>
+<span class="sourceLineNo">380</span> MetaTableAccessor.addRegionsToMeta(env.getMasterServices().getConnection(), regionInfos,<a name="line.380"></a>
+<span class="sourceLineNo">381</span> tableDescriptor.getRegionReplication());<a name="line.381"></a>
+<span class="sourceLineNo">382</span> }<a name="line.382"></a>
+<span class="sourceLineNo">383</span> /**<a name="line.383"></a>
+<span class="sourceLineNo">384</span> * Action after modifying table.<a name="line.384"></a>
+<span class="sourceLineNo">385</span> * @param env MasterProcedureEnv<a name="line.385"></a>
+<span class="sourceLineNo">386</span> * @param state the procedure state<a name="line.386"></a>
+<span class="sourceLineNo">387</span> * @throws IOException<a name="line.387"></a>
+<span class="sourceLineNo">388</span> * @throws InterruptedException<a name="line.388"></a>
+<span class="sourceLineNo">389</span> */<a name="line.389"></a>
+<span class="sourceLineNo">390</span> private void postModify(final MasterProcedureEnv env, final ModifyTableState state)<a name="line.390"></a>
+<span class="sourceLineNo">391</span> throws IOException, InterruptedException {<a name="line.391"></a>
+<span class="sourceLineNo">392</span> runCoprocessorAction(env, state);<a name="line.392"></a>
+<span class="sourceLineNo">393</span> }<a name="line.393"></a>
+<span class="sourceLineNo">394</span><a name="line.394"></a>
+<span class="sourceLineNo">395</span> /**<a name="line.395"></a>
+<span class="sourceLineNo">396</span> * The procedure could be restarted from a different machine. If the variable is null, we need to<a name="line.396"></a>
+<span class="sourceLineNo">397</span> * retrieve it.<a name="line.397"></a>
+<span class="sourceLineNo">398</span> * @return traceEnabled whether the trace is enabled<a name="line.398"></a>
<span class="sourceLineNo">399</span> */<a name="line.399"></a>
-<span class="sourceLineNo">400</span> private void runCoprocessorAction(final MasterProcedureEnv env, final ModifyTableState state)<a name="line.400"></a>
-<span class="sourceLineNo">401</span> throws IOException, InterruptedException {<a name="line.401"></a>
-<span class="sourceLineNo">402</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.402"></a>
-<span class="sourceLineNo">403</span> if (cpHost != null) {<a name="line.403"></a>
-<span class="sourceLineNo">404</span> switch (state) {<a name="line.404"></a>
-<span class="sourceLineNo">405</span> case MODIFY_TABLE_PRE_OPERATION:<a name="line.405"></a>
-<span class="sourceLineNo">406</span> cpHost.preModifyTableAction(getTableName(), modifiedTableDescriptor, getUser());<a name="line.406"></a>
-<span class="sourceLineNo">407</span> break;<a name="line.407"></a>
-<span class="sourceLineNo">408</span> case MODIFY_TABLE_POST_OPERATION:<a name="line.408"></a>
-<span class="sourceLineNo">409</span> cpHost.postCompletedModifyTableAction(getTableName(), modifiedTableDescriptor,getUser());<a name="line.409"></a>
-<span class="sourceLineNo">410</span> break;<a name="line.410"></a>
-<span class="sourceLineNo">411</span> default:<a name="line.411"></a>
-<span class="sourceLineNo">412</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.412"></a>
-<span class="sourceLineNo">413</span> }<a name="line.413"></a>
-<span class="sourceLineNo">414</span> }<a name="line.414"></a>
-<span class="sourceLineNo">415</span> }<a name="line.415"></a>
-<span class="sourceLineNo">416</span><a name="line.416"></a>
-<span class="sourceLineNo">417</span> private List<RegionInfo> getRegionInfoList(final MasterProcedureEnv env) throws IOException {<a name="line.417"></a>
-<span class="sourceLineNo">418</span> if (regionInfoList == null) {<a name="line.418"></a>
-<span class="sourceLineNo">419</span> regionInfoList = env.getAssignmentManager().getRegionStates()<a name="line.419"></a>
-<span class="sourceLineNo">420</span> .getRegionsOfTable(getTableName());<a name="line.420"></a>
-<span class="sourceLineNo">421</span> }<a name="line.421"></a>
-<span class="sourceLineNo">422</span> return regionInfoList;<a name="line.422"></a>
-<span class="sourceLineNo">423</span> }<a name="line.423"></a>
-<span class="sourceLineNo">424</span>}<a name="line.424"></a>
+<span class="sourceLineNo">400</span> private Boolean isTraceEnabled() {<a name="line.400"></a>
+<span class="sourceLineNo">401</span> if (traceEnabled == null) {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> traceEnabled = LOG.isTraceEnabled();<a name="line.402"></a>
+<span class="sourceLineNo">403</span> }<a name="line.403"></a>
+<span class="sourceLineNo">404</span> return traceEnabled;<a name="line.404"></a>
+<span class="sourceLineNo">405</span> }<a name="line.405"></a>
+<span class="sourceLineNo">406</span><a name="line.406"></a>
+<span class="sourceLineNo">407</span> /**<a name="line.407"></a>
+<span class="sourceLineNo">408</span> * Coprocessor Action.<a name="line.408"></a>
+<span class="sourceLineNo">409</span> * @param env MasterProcedureEnv<a name="line.409"></a>
+<span class="sourceLineNo">410</span> * @param state the procedure state<a name="line.410"></a>
+<span class="sourceLineNo">411</span> * @throws IOException<a name="line.411"></a>
+<span class="sourceLineNo">412</span> * @throws InterruptedException<a name="line.412"></a>
+<span class="sourceLineNo">413</span> */<a name="line.413"></a>
+<span class="sourceLineNo">414</span> private void runCoprocessorAction(final MasterProcedureEnv env, final ModifyTableState state)<a name="line.414"></a>
+<span class="sourceLineNo">415</span> throws IOException, InterruptedException {<a name="line.415"></a>
+<span class="sourceLineNo">416</span> final MasterCoprocessorHost cpHost = env.getMasterCoprocessorHost();<a name="line.416"></a>
+<span class="sourceLineNo">417</span> if (cpHost != null) {<a name="line.417"></a>
+<span class="sourceLineNo">418</span> switch (state) {<a name="line.418"></a>
+<span class="sourceLineNo">419</span> case MODIFY_TABLE_PRE_OPERATION:<a name="line.419"></a>
+<span class="sourceLineNo">420</span> cpHost.preModifyTableAction(getTableName(), modifiedTableDescriptor, getUser());<a name="line.420"></a>
+<span class="sourceLineNo">421</span> break;<a name="line.421"></a>
+<span class="sourceLineNo">422</span> case MODIFY_TABLE_POST_OPERATION:<a name="line.422"></a>
+<span class="sourceLineNo">423</span> cpHost.postCompletedModifyTableAction(getTableName(), modifiedTableDescriptor,getUser());<a name="line.423"></a>
+<span class="sourceLineNo">424</span> break;<a name="line.424"></a>
+<span class="sourceLineNo">425</span> default:<a name="line.425"></a>
+<span class="sourceLineNo">426</span> throw new UnsupportedOperationException(this + " unhandled state=" + state);<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span> }<a name="line.428"></a>
+<span class="sourceLineNo">429</span> }<a name="line.429"></a>
+<span class="sourceLineNo">430</span><a name="line.430"></a>
+<span class="sourceLineNo">431</span> private List<RegionInfo> getRegionInfoList(final MasterProcedureEnv env) throws IOException {<a name="line.431"></a>
+<span class="sourceLineNo">432</span> if (regionInfoList == null) {<a name="line.432"></a>
+<span class="sourceLineNo">433</span> regionInfoList = env.getAssignmentManager().getRegionStates()<a name="line.433"></a>
+<span class="sourceLineNo">434</span> .getRegionsOfTable(getTableName());<a name="line.434"></a>
+<span class="sourceLineNo">435</span> }<a name="line.435"></a>
+<span class="sourceLineNo">436</span> return regionInfoList;<a name="line.436"></a>
+<span class="sourceLineNo">437</span> }<a name="line.437"></a>
+<span class="sourceLineNo">438</span>}<a name="line.438"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/73598816/export_control.html
----------------------------------------------------------------------
diff --git a/export_control.html b/export_control.html
index 1ad8962..b3a457b 100644
--- a/export_control.html
+++ b/export_control.html
@@ -7,7 +7,7 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
- <meta name="Date-Revision-yyyymmdd" content="20171002" />
+ <meta name="Date-Revision-yyyymmdd" content="20171003" />
<meta http-equiv="Content-Language" content="en" />
<title>Apache HBase –
Export Control
@@ -336,7 +336,7 @@ for more details.</p>
<a href="https://www.apache.org/">The Apache Software Foundation</a>.
All rights reserved.
- <li id="publishDate" class="pull-right">Last Published: 2017-10-02</li>
+ <li id="publishDate" class="pull-right">Last Published: 2017-10-03</li>
</p>
</div>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/73598816/hbase-annotations/dependencies.html
----------------------------------------------------------------------
diff --git a/hbase-annotations/dependencies.html b/hbase-annotations/dependencies.html
index 84ab45c..fdbe80f 100644
--- a/hbase-annotations/dependencies.html
+++ b/hbase-annotations/dependencies.html
@@ -7,7 +7,7 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
- <meta name="Date-Revision-yyyymmdd" content="20171002" />
+ <meta name="Date-Revision-yyyymmdd" content="20171003" />
<meta http-equiv="Content-Language" content="en" />
<title>Apache HBase - Annotations – Project Dependencies</title>
<link rel="stylesheet" href="./css/apache-maven-fluido-1.5-HBASE.min.css" />
@@ -272,7 +272,7 @@
<a href="https://www.apache.org/">The Apache Software Foundation</a>.
All rights reserved.
- <li id="publishDate" class="pull-right">Last Published: 2017-10-02</li>
+ <li id="publishDate" class="pull-right">Last Published: 2017-10-03</li>
</p>
</div>