You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/06/21 18:35:42 UTC
[jira] [Created] (BOOKKEEPER-307) BookieShell introduces 4 findbugs
warnings
Ivan Kelly created BOOKKEEPER-307:
-------------------------------------
Summary: BookieShell introduces 4 findbugs warnings
Key: BOOKKEEPER-307
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.2.0
Attachments: BOOKKEEPER-307.diff
One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-307) BookieShell introduces 4 findbugs
warnings
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-307:
----------------------------------
Attachment: BOOKKEEPER-307.diff
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
> Key: BOOKKEEPER-307
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-307) BookieShell introduces 4
findbugs warnings
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401973#comment-13401973 ]
Hudson commented on BOOKKEEPER-307:
-----------------------------------
Integrated in bookkeeper-trunk #578 (See [https://builds.apache.org/job/bookkeeper-trunk/578/])
BOOKKEEPER-307: BookieShell introduces 4 findbugs warnings (ivank via sijie) (Revision 1354326)
Result = FAILURE
sijie :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
> Key: BOOKKEEPER-307
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-307.diff, BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-307) BookieShell introduces 4
findbugs warnings
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401961#comment-13401961 ]
Sijie Guo commented on BOOKKEEPER-307:
--------------------------------------
+1 for the patch.
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
> Key: BOOKKEEPER-307
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-307.diff, BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-307) BookieShell introduces 4
findbugs warnings
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399121#comment-13399121 ]
Rakesh R commented on BOOKKEEPER-307:
-------------------------------------
simple and good fix.
I have one suggestion, few unused imports also exists in the BookieShell class. It would be good doing the cleanup now as we are touching the class.
{code}
import java.io.RandomAccessFile;
import java.util.List;
import org.apache.commons.configuration.ConfigurationException;
{code}
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
> Key: BOOKKEEPER-307
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-307) BookieShell introduces 4
findbugs warnings
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399083#comment-13399083 ]
Uma Maheswara Rao G commented on BOOKKEEPER-307:
------------------------------------------------
+1 patch looks good to me. One question: long length = recBuff.getLong(); is this one a mistake of including length in out message before?
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
> Key: BOOKKEEPER-307
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-307) BookieShell introduces 4 findbugs
warnings
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-307:
----------------------------------
Attachment: BOOKKEEPER-307.diff
Removed unused imports.
> BookieShell introduces 4 findbugs warnings
> ------------------------------------------
>
> Key: BOOKKEEPER-307
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-307
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-307.diff, BOOKKEEPER-307.diff
>
>
> One is an empty store. The other is about synchronized access to the journal. Easy fixes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira