[GitHub] [arrow] rok commented on a diff in pull request #14434: ARROW-15538: [C++] Expanding coverage of math functions from Substrait to Acero

[GitBox <gi...@apache.org>]

rok commented on code in PR #14434:
URL: https://github.com/apache/arrow/pull/14434#discussion_r1023328835


##########
docs/source/cpp/compute.rst:
##########
@@ -450,6 +450,18 @@ Mixed time resolution temporal inputs will be cast to finest input resolution.
 +------------------+--------+------------------+----------------------+-------+
 | divide_checked   | Binary | Numeric/Temporal | Numeric/Temporal     | \(1)  |
 +------------------+--------+------------------+----------------------+-------+
+| exp              | Unary  | Numeric          | Numeric              |       |

Review Comment:
   Wouldn't integer be a valid input type and hence input type remains `Numeric`? `Float32/Float64` as output makes sense.
   
   This is out of scope for this PR, but how about `complex` values ([example](https://numpy.org/devdocs/reference/generated/numpy.exp.html))? Should Acero kernels support complex? What about Substrait?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org