You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/07/31 22:09:51 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #36964: GH-36935: [Go] Fix Timestamp to Time dates
zeroshade opened a new pull request, #36964:
URL: https://github.com/apache/arrow/pull/36964
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
The previous solution converted everything to nanoseconds first but you end up with overflowing `int64` potentially. Since we've bumped the minimum version of the library to using go1.17+ we can use the newer `UnixMicro` and `UnixMilli` functions to make this easy.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### Are these changes tested?
Yes, unit test is added.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36964: GH-36935: [Go] Fix Timestamp to Time dates
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36964:
URL: https://github.com/apache/arrow/pull/36964#issuecomment-1671705656
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 0fb744cb6029a9b7c8faa38205d73f94118ec7c5.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15754430131) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36964: GH-36935: [Go] Fix Timestamp to Time dates
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36964:
URL: https://github.com/apache/arrow/pull/36964#issuecomment-1659257979
:warning: GitHub issue #36935 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #36964: GH-36935: [Go] Fix Timestamp to Time dates
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #36964:
URL: https://github.com/apache/arrow/pull/36964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] candiduslynx commented on pull request #36964: GH-36935: [Go] Fix Timestamp to Time dates
Posted by "candiduslynx (via GitHub)" <gi...@apache.org>.
candiduslynx commented on PR #36964:
URL: https://github.com/apache/arrow/pull/36964#issuecomment-1699025641
@zeroshade doesn't this code also need to be accounted for in the [`arrow.TimestampType.GetToTimeFunc`](https://pkg.go.dev/github.com/apache/arrow/go/v14/arrow#TimestampType.GetToTimeFunc)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #36964: GH-36935: [Go] Fix Timestamp to Time dates
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #36964:
URL: https://github.com/apache/arrow/pull/36964#issuecomment-1659258058
CC @senekis Please try this with your issue and confirm it fixes the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] senekis commented on pull request #36964: GH-36935: [Go] Fix Timestamp to Time dates
Posted by "senekis (via GitHub)" <gi...@apache.org>.
senekis commented on PR #36964:
URL: https://github.com/apache/arrow/pull/36964#issuecomment-1659371615
thanks @zeroshade, I tested and can confirm this change fix the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org