[jira] Commented: (DERBY-4052) SQLChar.copyState() doesn't copy localeFinder

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886342#action_12886342 ] 

Knut Anders Hatlen commented on DERBY-4052:
-------------------------------------------

Hi Yun. The patch looks fine to me. Did you run the regression tests to see if it caused any problems?

> SQLChar.copyState() doesn't copy localeFinder
> ---------------------------------------------
>
>                 Key: DERBY-4052
>                 URL: https://issues.apache.org/jira/browse/DERBY-4052
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.5.1.1
>            Reporter: Knut Anders Hatlen
>            Assignee: Yun Lee
>            Priority: Minor
>         Attachments: derby-4052.patch, derby-4052.stat
>
>
> The last line of SQLChar.copyState() looks incorrect.
>         this.localeFinder = localeFinder;
> This line doesn't do anything, since the left side and the right side of the assignment are identical.
> It might be intentional, but in that case there should be a comment explaining why. Looking at the rest of the method, it looks like the intention is that the right side of the assignment should be other.localeFinder.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.