[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #207: Add external schema mappings for files written with name-based schemas #40
URL: https://github.com/apache/incubator-iceberg/pull/207#discussion_r326875973
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
 ##########
 @@ -170,6 +171,7 @@ public static ReadBuilder read(InputFile file) {
     private final ClassLoader defaultLoader = Thread.currentThread().getContextClassLoader();
     private final InputFile file;
     private final Map<String, String> renames = Maps.newLinkedHashMap();
+    private NameMapping nameMapping;
 
 Review comment:
   Instance fields should be defaulted. Can you set this to `null`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org