You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2023/12/26 02:09:42 UTC
[PR] Update project description and add access log documentation [skywalking-rover]
mrproliu opened a new pull request, #108:
URL: https://github.com/apache/skywalking-rover/pull/108
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108#issuecomment-1869199944
Yes, I will add a new Kubernetes deploy documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108#issuecomment-1869198282
https://skywalking.apache.org/docs/skywalking-rover/next/en/setup/overview/#skywalking-oap This part should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108#issuecomment-1869200535
I think from now on, running on k8s is the first and most important use case, until we are going to monitor VM service through eBPF(but not now).
The previous use cases seem to be a little advanced features only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108#discussion_r1436194724
##########
docs/en/setup/configuration/accesslog.md:
##########
@@ -0,0 +1,47 @@
+# Access Log Module
Review Comment:
You miss the menu item for this new doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108#discussion_r1437487205
##########
docs/en/setup/overview.md:
##########
@@ -15,7 +15,8 @@ The SkyWalking Rover requires specialized protocols to communicate with SkyWalki
| SkyWalking Rover Version | SkyWalking OAP |
|--------------------------|----------------|
-|0.1.0+ | \> = 9.1.0 |
+| 0.1.0+ | \> = 9.1.0 |
Review Comment:
Let's remove 0.1, after all, we changed the landscape of the project in 0.6. We should make this changing very clear in the release note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update project description and add access log documentation [skywalking-rover]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #108:
URL: https://github.com/apache/skywalking-rover/pull/108#issuecomment-1869199432
And Configuration and Use Cases should be updated too.
Meanwhile, I can only see deploy on Linux, where is on K8s? The access log requires k8s, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org