You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "changgyoopark-db (via GitHub)" <gi...@apache.org> on 2024/11/05 13:15:27 UTC

Re: [PR] [SPARK-50028][CONNECT] Replace global locks in Spark Connect server listener with fine-grained locks [spark]

changgyoopark-db commented on PR #48544:
URL: https://github.com/apache/spark/pull/48544#issuecomment-2457144632

   @HyukjinKwon @dongjoon-hyun Hi, can you possibly review this change? (nobody's looking at this PR..)
   
   What this PR does is,
   - Replace "synchronized" blocked with ConcurrentHashMap.
   - updateLiveStore and updateStoreWithTriggerEnabled instead provide entry-level synchronization.
   
   Therefore, in short, previously, the granularity of locking was of SparkConnectServerListener, and this PR proposes individual entry-level locking.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org