You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/10 09:08:54 UTC

[GitHub] [skywalking-swck] dashanji opened a new pull request #58: use JAVA_TOOL_OPTIONS to replace AGENT_OPTS

dashanji opened a new pull request #58:
URL: https://github.com/apache/skywalking-swck/pull/58


   Signed-off-by: dashanji <95...@qq.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-swck] hanahmily merged pull request #58: use JAVA_TOOL_OPTIONS to replace AGENT_OPTS

Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #58:
URL: https://github.com/apache/skywalking-swck/pull/58


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-swck] wu-sheng commented on pull request #58: use JAVA_TOOL_OPTIONS to replace AGENT_OPTS

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #58:
URL: https://github.com/apache/skywalking-swck/pull/58#issuecomment-1008672460


   @hanahmily Please confirm whether we still accept PR in 0.6.0 release RC


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-swck] wu-sheng commented on pull request #58: use JAVA_TOOL_OPTIONS to replace AGENT_OPTS

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #58:
URL: https://github.com/apache/skywalking-swck/pull/58#issuecomment-1008680432


   Make sense to me. Wait for release manager's confirmation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-swck] wu-sheng commented on pull request #58: use JAVA_TOOL_OPTIONS to replace AGENT_OPTS

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #58:
URL: https://github.com/apache/skywalking-swck/pull/58#issuecomment-1008675145


   Could you explain or provide some references about differences between `JAVA_TOOL_OPTIONS` and `AGENT_OPTS`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-swck] dashanji commented on pull request #58: use JAVA_TOOL_OPTIONS to replace AGENT_OPTS

Posted by GitBox <gi...@apache.org>.
dashanji commented on pull request #58:
URL: https://github.com/apache/skywalking-swck/pull/58#issuecomment-1008678408


   @wu-sheng yep, I think the difference is [here](https://github.com/apache/skywalking-showcase/pull/14#discussion_r775429367).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org