You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Sammy <no...@github.com> on 2020/04/15 06:48:42 UTC

[apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

## Observation
During daily development with this great SDK, we have to copy theses [edls](https://github.com/apache/incubator-teaclave-sgx-sdk/tree/master/edl) to local file system to use as extra searching paths for the `sgx_edger8r` tool for every project.

There isn't any version control for these edls.

Considering our projects with this SDK using rust and cargo, I think it would be nice to collect all these edls as a crate. If done, it would be possible for us to just collect these edls using `cargo vendor` command with a Cargo.toml specifying this crate as the only dependency. This also helps the version control.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

Posted by Sammy <no...@github.com>.
It has been done at https://github.com/apache/incubator-teaclave-sgx-sdk/commit/df76765f586cf103189a5e62355672c96f4920ce

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#issuecomment-628998723

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

Posted by Sammy <no...@github.com>.
Closed #224.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#event-3339156320

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

Posted by Sammy <no...@github.com>.
I would be better if the common folder can be put into that crate also~ @volcano0dr 

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#issuecomment-615540175

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

Posted by volcano <no...@github.com>.
Good idea! I will consider using a  crate to control and compile these edls.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#issuecomment-615534530