You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/01/17 00:54:23 UTC

[GitHub] alvarop commented on a change in pull request #1600: Only erase FLASH_BANK_2 when available

alvarop commented on a change in pull request #1600: Only erase FLASH_BANK_2 when available
URL: https://github.com/apache/mynewt-core/pull/1600#discussion_r248506729
 
 

 ##########
 File path: hw/mcu/stm/stm32l4xx/src/hal_flash.c
 ##########
 @@ -38,9 +38,12 @@ stm32_mcu_flash_erase_sector(const struct hal_flash *dev, uint32_t sector_addres
         eraseinit.TypeErase = FLASH_TYPEERASE_PAGES;
         if ((sector_address - dev->hf_base_addr) < (_FLASH_SIZE / 2)) {
 
 Review comment:
   Good call! Didn't even think of that. IO'll take a look

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services