[GitHub] [mynewt-nimble] mfarag13 commented on issue #432: nimble/l2cap: Generalize L2CAP COC Dynamic Channel Allocation.

[GitBox <gi...@apache.org>]

mfarag13 commented on issue #432: nimble/l2cap: Generalize L2CAP COC Dynamic Channel Allocation.
URL: https://github.com/apache/mynewt-nimble/pull/432#issuecomment-545003206
 
 
   > 
   > 
   > @mfarag13 sorry for long silence, I was busy with other stuff. Still I wanted to ask you for some changes, but I've decided to make it by myself since I was not fast enough in the review.
   > 
   > Please have a look here, test and say if it works for you
   > 
   > #619
   
   @rymanluk I have checked your PR and added some comments. I think its better to add your comments here rather than doing a new PR with the same Idea and code snippets. This is a duplicate of efforts and wasting of my time specially there are issues that needs to be resolved(Travis), which is already done in this PR. 
   
   I think it's not ethical to get someone work and get the credit for it.
   There are a lot of pending PR and many PRs to open (For Example: GATT/ATT Queuing) which is already implemented and tested and waiting for accepting the pending PRs.
   It's up to you to accept or reject this PR. But I think if this is the attitude you will lose interest of a lot of contributors. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services