You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/09/19 11:22:02 UTC
[GitHub] carbondata pull request #1370: [CARBONDATA-1488] JVM crashes when unsafe col...
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/1370
[CARBONDATA-1488] JVM crashes when unsafe columnpage is enabled
The test case `BadRecordEmptyDataTest.test load multiple loads- pne with valid record and one with invalid` crashes when unsafe columnpage is enabled
It is because of capacity size calculation in unsafe var page.
Fixed capacity size calculation when column value size is larger than initial capacity in this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata presto-build-all
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1370
----
commit 058ad83940dcc77f3f279188eadd79f1d01b27df
Author: Ravindra Pesala <ra...@gmail.com>
Date: 2017-09-19T10:54:35Z
Fixed capacity size calculation when column value size is larger than initial capacity
----
---
[GitHub] carbondata issue #1370: [CARBONDATA-1488] JVM crashes when unsafe columnpage...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1370
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/110/
---
[GitHub] carbondata issue #1370: [CARBONDATA-1488] JVM crashes when unsafe columnpage...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1370
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/865/
---
[GitHub] carbondata pull request #1370: [CARBONDATA-1488] JVM crashes when unsafe col...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1370
---
[GitHub] carbondata pull request #1370: [CARBONDATA-1488] JVM crashes when unsafe col...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1370#discussion_r139664120
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorizedRecordReader.java ---
@@ -72,7 +72,7 @@
/**
* The default config on whether columnarBatch should be offheap.
--- End diff --
please change comment also
---
[GitHub] carbondata issue #1370: [CARBONDATA-1488] JVM crashes when unsafe columnpage...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1370
LGTM
---
[GitHub] carbondata issue #1370: [CARBONDATA-1488] JVM crashes when unsafe columnpage...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1370
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/864/
---
[GitHub] carbondata pull request #1370: [CARBONDATA-1488] JVM crashes when unsafe col...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1370#discussion_r139664458
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorizedRecordReader.java ---
@@ -72,7 +72,7 @@
/**
* The default config on whether columnarBatch should be offheap.
--- End diff --
ok
---
[GitHub] carbondata issue #1370: [CARBONDATA-1488] JVM crashes when unsafe columnpage...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1370
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/234/
---