You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2017/01/23 05:15:50 UTC
[GitHub] zeppelin pull request #1932: [ZEPPELIN-2000] Run paragraph on enter when sel...
GitHub user minahlee opened a pull request:
https://github.com/apache/zeppelin/pull/1932
[ZEPPELIN-2000] Run paragraph on enter when select dynamic form value changed
### What is this PR for?
Run paragraph on enter when select dynamic form value changed to make paragraph runnable in report mode.
### What type of PR is it?
Bug Fix | Hot Fix
### What is the Jira issue?
[ZEPPELIN-2000](https://issues.apache.org/jira/browse/ZEPPELIN-2000)
### How should this be tested?
1. Go to `Zeppelin Tutorial/Basic Features (Spark)` notebook
2. Change view mode to `report`.
3. Change selected value from `married` to `single` in 5th paragraph and hit enter.
4. See if paragraph runs
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes. docs update included.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/zeppelin ZEPPELIN-2000
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1932.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1932
----
commit 66b513c58f05c7b4d23a5580751545638df7a849
Author: Mina Lee <mi...@apache.org>
Date: 2017-01-23T05:00:46Z
Run paragraph onEnter when select value changed
commit a9f02d29672beadca1b3a2af591e6e9f06246f08
Author: Mina Lee <mi...@apache.org>
Date: 2017-01-23T05:08:38Z
Update docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1932: [ZEPPELIN-2000] Run paragraph on enter when sel...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1932: [ZEPPELIN-2000] Run paragraph on enter when select dyn...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1932
LGTM! Tested as described and it worked very well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1932: [ZEPPELIN-2000] Run paragraph on enter when select dyn...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1932
LGTM. @minahlee Can you merge it asap and make a new rc, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---