You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "dgetzlaf (via GitHub)" <gi...@apache.org> on 2023/03/16 12:41:33 UTC

[GitHub] [jmeter] dgetzlaf opened a new pull request, #5792: Add KeyStroke for start_no_timers (Start no pauses)

dgetzlaf opened a new pull request, #5792:
URL: https://github.com/apache/jmeter/pull/5792

   ## Description
   Add an additional KeyStroke to Start a local test, skipping the Timers.
   
   ## Motivation and Context
   In our daily doing we setup load tests, using Timers.
   For faster test preparation, we want to skip timers.
   
   ## How Has This Been Tested?
   ./gradlew createDist
   ./bin/jmeter -t Testplan-with-pauses.jmx
   
   Execute Testplan with Crtl-R
   Execute Testplan with Ctrl-Shift-N
   
   > Testplan will be executed, skipping the timers
   
   ## Types of changes
   - New feature (non-breaking change which adds functionality)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] milamberspace merged pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)

Posted by "milamberspace (via GitHub)" <gi...@apache.org>.
milamberspace merged PR #5792:
URL: https://github.com/apache/jmeter/pull/5792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] dgetzlaf commented on pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)

Posted by "dgetzlaf (via GitHub)" <gi...@apache.org>.
dgetzlaf commented on PR #5792:
URL: https://github.com/apache/jmeter/pull/5792#issuecomment-1472105291

   Also this page needs to be updated afterwards:
   https://cwiki.apache.org/confluence/display/JMETER/JMeterShortcuts
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] milamberspace commented on pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)

Posted by "milamberspace (via GitHub)" <gi...@apache.org>.
milamberspace commented on PR #5792:
URL: https://github.com/apache/jmeter/pull/5792#issuecomment-1519647406

   Why close the PR? they aren't merge into main source?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] milamberspace commented on pull request #5792: Add KeyStroke for start_no_timers (Start no pauses: CRTL+SHIFT+n)

Posted by "milamberspace (via GitHub)" <gi...@apache.org>.
milamberspace commented on PR #5792:
URL: https://github.com/apache/jmeter/pull/5792#issuecomment-1520234196

   > Also this page needs to be updated afterwards: https://cwiki.apache.org/confluence/display/JMETER/JMeterShortcuts
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] dgetzlaf closed pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)

Posted by "dgetzlaf (via GitHub)" <gi...@apache.org>.
dgetzlaf closed pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)
URL: https://github.com/apache/jmeter/pull/5792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] FSchumacher commented on a diff in pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)

Posted by "FSchumacher (via GitHub)" <gi...@apache.org>.
FSchumacher commented on code in PR #5792:
URL: https://github.com/apache/jmeter/pull/5792#discussion_r1174552638


##########
src/core/src/main/java/org/apache/jmeter/gui/action/KeyStrokes.java:
##########
@@ -72,6 +72,7 @@ private static int getMenuShortcutKeyMask() {
     public static final KeyStroke OPEN              = KeyStroke.getKeyStroke(KeyEvent.VK_O, CONTROL_MASK);
     public static final KeyStroke EXIT              = KeyStroke.getKeyStroke(KeyEvent.VK_Q, CONTROL_MASK);
     public static final KeyStroke ACTION_START      = KeyStroke.getKeyStroke(KeyEvent.VK_R, CONTROL_MASK);
+    public static final KeyStroke ACTION_START_NO_PAUSE  = KeyStroke.getKeyStroke(KeyEvent.VK_N, CONTROL_MASK | InputEvent.SHIFT_DOWN_MASK);

Review Comment:
   `Ctrl`+`Shift`+`N` feels a bit like a command to create something *new*. But as the menu shortcut uses `n` already, this seems to be a natural choice here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jmeter] dgetzlaf commented on pull request #5792: Add KeyStroke for start_no_timers (Start no pauses)

Posted by "dgetzlaf (via GitHub)" <gi...@apache.org>.
dgetzlaf commented on PR #5792:
URL: https://github.com/apache/jmeter/pull/5792#issuecomment-1520072502

   @milamberspace yes, you are absolutely right!
   I do not know what my head was thinking at that moment @.@
   I've re-opened this PR..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org