You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by paul-rogers <gi...@git.apache.org> on 2017/10/01 00:20:12 UTC

[GitHub] drill pull request #968: DRILL-5830: Resolve regressions to MapR DB from DRI...

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/968#discussion_r142017916
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java ---
    @@ -0,0 +1,113 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.test;
    +
    +import java.util.Iterator;
    +
    +import org.apache.drill.exec.exception.SchemaChangeException;
    +import org.apache.drill.exec.memory.BufferAllocator;
    +import org.apache.drill.exec.proto.UserBitShared.QueryId;
    +import org.apache.drill.exec.proto.UserBitShared.QueryResult.QueryState;
    +import org.apache.drill.exec.proto.helper.QueryIdHelper;
    +import org.apache.drill.exec.record.RecordBatchLoader;
    +import org.apache.drill.exec.record.VectorContainer;
    +import org.apache.drill.exec.rpc.user.QueryDataBatch;
    +import org.apache.drill.test.BufferingQueryEventListener.QueryEvent;
    +import org.apache.drill.test.rowSet.DirectRowSet;
    +
    +public class QueryRowSetIterator implements Iterator<DirectRowSet>, Iterable<DirectRowSet> {
    --- End diff --
    
    Sorry, this is a Java 8 thing. In Java 8, `remove()` has a default implementation. In Java 7, the method must be implemented. Fixed.


---