You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by BryanCutler <gi...@git.apache.org> on 2016/06/28 18:13:17 UTC

[GitHub] spark pull request #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNa...

GitHub user BryanCutler opened a pull request:

    https://github.com/apache/spark/pull/13949

    [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ML Examples

    ## What changes were proposed in this pull request?
    
    Some appNames in ML examples are incorrect, mostly in PySpark but one in Scala.  This corrects the names.
    
    
    ## How was this patch tested?
    Style, local tests
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BryanCutler/spark pyspark-example-appNames-fix-SPARK-16261

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/13949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13949
    
----
commit 8f9c5cc0439b1e6b52e3d44e5218580b684203cc
Author: Bryan Cutler <cu...@gmail.com>
Date:   2016-06-28T18:09:50Z

    fixed incorrect appNames

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by BryanCutler <gi...@git.apache.org>.

Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    Thanks Nick and Sean!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by MLnick <gi...@git.apache.org>.

Github user MLnick commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    LGTM too - I've merged to master/branch-2.0. Set the JIRA fix version to `2.0.1` for now since that seems the be what we're doing. I guess when RC2 is cut we will re-assign those ones... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    **[Test build #61395 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61395/consoleFull)** for PR 13949 at commit [`8f9c5cc`](https://github.com/apache/spark/commit/8f9c5cc0439b1e6b52e3d44e5218580b684203cc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    **[Test build #61395 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61395/consoleFull)** for PR 13949 at commit [`8f9c5cc`](https://github.com/apache/spark/commit/8f9c5cc0439b1e6b52e3d44e5218580b684203cc).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61395/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #13949: [SPARK-16261][EXAMPLES][ML] Fixed incorrect appNames in ...

Posted by BryanCutler <gi...@git.apache.org>.

Github user BryanCutler commented on the issue:

    https://github.com/apache/spark/pull/13949
  
    Not sure if this is something worth squeezing into 2.0, but I thought I'd patch it now in case.
    cc @mengxr @jkbradley 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org