You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wsjz (via GitHub)" <gi...@apache.org> on 2023/04/26 06:24:13 UTC
[GitHub] [doris] wsjz opened a new pull request, #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
wsjz opened a new pull request, #19098:
URL: https://github.com/apache/doris/pull/19098
# Proposed changes
see https://github.com/apache/doris/issues/18960
PR1: add new storage file system template and move old storage to new package
PR2: extract some method in old storage to new file system.
PR3: use storages to access remote object storage, and use file systems to access file in local or remote location. Will add some unit tests.
this is PR3.
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1535772405
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #19098:
URL: https://github.com/apache/doris/pull/19098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1523004801
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1529754728
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1185637063
##########
fe/fe-core/src/main/java/org/apache/doris/fs/remote/RemoteFileSystem.java:
##########
@@ -34,17 +37,31 @@ public RemoteFileSystem(String name, StorageBackend.StorageType type) {
super(name, type);
}
- protected org.apache.hadoop.fs.FileSystem getFileSystem(String remotePath) throws UserException {
+ protected org.apache.hadoop.fs.FileSystem nativeFileSystem(String remotePath) throws UserException {
Review Comment:
BrokerFileSystem don't need，and it has no origin fs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1535631440
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1529415412
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1184848626
##########
fe/fe-core/src/main/java/org/apache/doris/external/hive/util/HiveUtil.java:
##########
@@ -204,8 +205,8 @@ public static boolean isSplittable(InputFormat<?, ?> inputFormat, FileSystem fil
}
try {
method.setAccessible(true);
- return (boolean) method.invoke(inputFormat, fileSystem, path);
- } catch (InvocationTargetException | IllegalAccessException e) {
+ return (boolean) method.invoke(inputFormat, path.getFileSystem(jobConf), path);
Review Comment:
Why not using `RemoteFileSystem.getByConf()`
##########
fe/fe-core/src/main/java/org/apache/doris/fs/FileLocations.java:
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.fs;
+
+import org.apache.doris.fs.remote.RemoteFile;
+
+import java.util.List;
+
+public class FileLocations {
Review Comment:
Looks like it is a list of RemoteFile.
Why name it `FileLocations`?
##########
fe/fe-core/src/main/java/org/apache/doris/fs/FileSystemFactory.java:
##########
@@ -49,4 +49,25 @@ public static FileSystem get(String name, StorageBackend.StorageType type, Map<S
throw new UnsupportedOperationException(type.toString() + "backend is not implemented");
}
}
+
+ public static RemoteFileSystem getByConf(String location, Configuration conf) {
Review Comment:
```suggestion
public static RemoteFileSystem getByLocation(String location, Configuration conf) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/fs/remote/RemoteFileSystem.java:
##########
@@ -34,17 +37,31 @@ public RemoteFileSystem(String name, StorageBackend.StorageType type) {
super(name, type);
}
- protected org.apache.hadoop.fs.FileSystem getFileSystem(String remotePath) throws UserException {
+ protected org.apache.hadoop.fs.FileSystem nativeFileSystem(String remotePath) throws UserException {
Review Comment:
Not implemented for BrokerFileSystem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1180345905
##########
fe/fe-core/src/main/java/org/apache/doris/fs/FileSystemFactory.java:
##########
@@ -33,7 +38,7 @@ public static FileSystem get(StorageBackend.StorageType type, Map<String, String
return get(type.name(), type, properties);
}
- public static FileSystem get(String name, StorageBackend.StorageType type, Map<String, String> properties) {
+ public static RemoteFileSystem get(String name, StorageBackend.StorageType type, Map<String, String> properties) {
Review Comment:
Can not remove it for now, it denpendent on Stmt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1180164738
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/HiveMetaStoreClientHelper.java:
##########
@@ -212,10 +213,10 @@ public static String normalizeS3LikeSchema(String location) {
}
private static String getAllFileStatus(List<TBrokerFileStatus> fileStatuses,
- List<RemoteIterator<LocatedFileStatus>> remoteIterators, BlobStorage storage) throws UserException {
- boolean needFullPath = storage.getStorageType() == StorageBackend.StorageType.S3
- || storage.getStorageType() == StorageBackend.StorageType.OFS
- || storage.getStorageType() == StorageBackend.StorageType.JFS;
+ List<RemoteIterator<LocatedFileStatus>> remoteIterators, RemoteFileSystem fs) throws UserException {
+ boolean needFullPath = fs.getStorageType() == StorageBackend.StorageType.S3
Review Comment:
Avoid this kind of code. Because if we add a new type of FS later, we may miss this place.
You can add a new interface `fs.needFullPath()` and handle it in the interface.
##########
fe/fe-core/src/main/java/org/apache/doris/fs/FileSystemFactory.java:
##########
@@ -33,7 +38,7 @@ public static FileSystem get(StorageBackend.StorageType type, Map<String, String
return get(type.name(), type, properties);
}
- public static FileSystem get(String name, StorageBackend.StorageType type, Map<String, String> properties) {
+ public static RemoteFileSystem get(String name, StorageBackend.StorageType type, Map<String, String> properties) {
Review Comment:
`StorageBackend.StorageType` can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1522856935
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1178555584
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/HiveMetaStoreClientHelper.java:
##########
@@ -212,7 +213,7 @@ public static String normalizeS3LikeSchema(String location) {
}
private static String getAllFileStatus(List<TBrokerFileStatus> fileStatuses,
- List<RemoteIterator<LocatedFileStatus>> remoteIterators, BlobStorage storage) throws UserException {
+ List<RemoteIterator<LocatedFileStatus>> remoteIterators, RemoteFileSystem storage) throws UserException {
Review Comment:
```suggestion
List<RemoteIterator<LocatedFileStatus>> remoteIterators, RemoteFileSystem fs) throws UserException {
```
##########
fe/fe-core/src/main/java/org/apache/doris/fs/LocalFileSystem.java:
##########
@@ -62,4 +63,9 @@ public Status makeDir(String remotePath) {
public Status list(String remotePath, List<RemoteFile> result, boolean fileNameOnly) {
return null;
}
+
+ @Override
+ public Map<String, String> getProperties() {
+ return null;
Review Comment:
Avoid return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1185637575
##########
fe/fe-core/src/main/java/org/apache/doris/fs/FileLocations.java:
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.fs;
+
+import org.apache.doris.fs.remote.RemoteFile;
+
+import java.util.List;
+
+public class FileLocations {
Review Comment:
Consider the subsequent extensions, we use the object instead the list of remotefile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1522984744
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1530878449
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1530984255
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1530964943
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1185636861
##########
fe/fe-core/src/main/java/org/apache/doris/external/hive/util/HiveUtil.java:
##########
@@ -204,8 +205,8 @@ public static boolean isSplittable(InputFormat<?, ?> inputFormat, FileSystem fil
}
try {
method.setAccessible(true);
- return (boolean) method.invoke(inputFormat, fileSystem, path);
- } catch (InvocationTargetException | IllegalAccessException e) {
+ return (boolean) method.invoke(inputFormat, path.getFileSystem(jobConf), path);
Review Comment:
we should use native hadoop fs here, RemoteFileSystem.getByConf() just return our fs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wsjz commented on a diff in pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "wsjz (via GitHub)" <gi...@apache.org>.
wsjz commented on code in PR #19098:
URL: https://github.com/apache/doris/pull/19098#discussion_r1185637063
##########
fe/fe-core/src/main/java/org/apache/doris/fs/remote/RemoteFileSystem.java:
##########
@@ -34,17 +37,31 @@ public RemoteFileSystem(String name, StorageBackend.StorageType type) {
super(name, type);
}
- protected org.apache.hadoop.fs.FileSystem getFileSystem(String remotePath) throws UserException {
+ protected org.apache.hadoop.fs.FileSystem nativeFileSystem(String remotePath) throws UserException {
Review Comment:
BrokerFileSystem don't need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19098: [refactor](fs)(step3)use filesystem instead of old storage, new storage just access remote object storage
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19098:
URL: https://github.com/apache/doris/pull/19098#issuecomment-1535772438
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org