[GitHub] [skywalking] hanahmily commented on pull request #7377: Add logging module to load log configuration dynamically

[GitBox <gi...@apache.org>]

hanahmily commented on pull request #7377:
URL: https://github.com/apache/skywalking/pull/7377#issuecomment-887941894


   > Before doing all the above doc side changes, I want to ask, why this dynamic log should be a new module rather than a feature inside the core module? It looks like no other modules depend on this one, and there is no chance to switch to a new implementation.
   
   Dynamic logging depends on the `configuration` module. Can a core component support such a constraint?
   
   After this PR, we need to support dynamic logging without `configuration`, a possible path is to inject log4j configuration through RESTful endpoint/GraphQL mutation, that's a new provider more than this one. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org