You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/06/05 10:53:27 UTC
Re: Review Request 33159: Pump updateFramework through Allocator from
Master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/
-----------------------------------------------------------
(Updated June 5, 2015, 8:53 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
rebased.
Bugs: MESOS-2615 and MESOS-703
https://issues.apache.org/jira/browse/MESOS-2615
https://issues.apache.org/jira/browse/MESOS-703
Repository: mesos
Description
-------
Follow up of 32961 where we add the 'updateFramework' function to the allocator.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87
src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993
src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4
src/master/master.cpp be0db42da3c59761aa154439653d715556465256
src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031
Diff: https://reviews.apache.org/r/33159/diff/
Testing
-------
make check
Thanks,
Joris Van Remoortere
Re: Review Request 33159: Pump updateFramework through Allocator from
Master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review86781
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.hpp
<https://reviews.apache.org/r/33159/#comment138859>
CHECK_EQ
- Benjamin Hindman
On June 5, 2015, 8:53 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33159/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:53 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-2615 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-2615
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow up of 32961 where we add the 'updateFramework' function to the allocator.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87
> src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993
> src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4
> src/master/master.cpp be0db42da3c59761aa154439653d715556465256
> src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031
>
> Diff: https://reviews.apache.org/r/33159/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 33159: Pump updateFramework through Allocator from
Master.
Posted by Vinod Kone <vi...@gmail.com>.
> On June 5, 2015, 5:42 p.m., Vinod Kone wrote:
> > src/master/allocator/mesos/hierarchical.hpp, lines 455-456
> > <https://reviews.apache.org/r/33159/diff/4/?file=979945#file979945line455>
> >
> > I don't follow. Why are these CHECKs? Is there currently code in the master that guarantees that these checks won't fail?
actually nm. looks like this is being called with framework->info in the master and not with the frameworkinfo that a framework re-registers with.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review86818
-----------------------------------------------------------
On June 5, 2015, 1:35 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33159/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 1:35 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-2615 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-2615
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow up of 32961 where we add the 'updateFramework' function to the allocator.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87
> src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993
> src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4
> src/master/master.cpp be0db42da3c59761aa154439653d715556465256
> src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031
>
> Diff: https://reviews.apache.org/r/33159/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 33159: Pump updateFramework through Allocator from
Master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review86818
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp
<https://reviews.apache.org/r/33159/#comment138910>
I don't follow. Why are these CHECKs? Is there currently code in the master that guarantees that these checks won't fail?
- Vinod Kone
On June 5, 2015, 1:35 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33159/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 1:35 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-2615 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-2615
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow up of 32961 where we add the 'updateFramework' function to the allocator.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87
> src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993
> src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4
> src/master/master.cpp be0db42da3c59761aa154439653d715556465256
> src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031
>
> Diff: https://reviews.apache.org/r/33159/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 33159: Pump updateFramework through Allocator from
Master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/
-----------------------------------------------------------
(Updated June 5, 2015, 1:35 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
switched CHECK to CHECK_EQ
Bugs: MESOS-2615 and MESOS-703
https://issues.apache.org/jira/browse/MESOS-2615
https://issues.apache.org/jira/browse/MESOS-703
Repository: mesos
Description
-------
Follow up of 32961 where we add the 'updateFramework' function to the allocator.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87
src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993
src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4
src/master/master.cpp be0db42da3c59761aa154439653d715556465256
src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031
Diff: https://reviews.apache.org/r/33159/diff/
Testing
-------
make check
Thanks,
Joris Van Remoortere
Re: Review Request 33159: Pump updateFramework through Allocator from
Master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review86783
-----------------------------------------------------------
Patch looks great!
Reviews applied: [32961, 33159]
All tests passed.
- Mesos ReviewBot
On June 5, 2015, 8:53 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33159/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 8:53 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-2615 and MESOS-703
> https://issues.apache.org/jira/browse/MESOS-2615
> https://issues.apache.org/jira/browse/MESOS-703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow up of 32961 where we add the 'updateFramework' function to the allocator.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87
> src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993
> src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4
> src/master/master.cpp be0db42da3c59761aa154439653d715556465256
> src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031
>
> Diff: https://reviews.apache.org/r/33159/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>