You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Wenchen Fan (Jira)" <ji...@apache.org> on 2020/12/02 16:12:00 UTC

[jira] [Resolved] (SPARK-33619) GetMapValueUtil code generation error

     [ https://issues.apache.org/jira/browse/SPARK-33619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wenchen Fan resolved SPARK-33619.
---------------------------------
    Fix Version/s: 3.1.0
       Resolution: Fixed

Issue resolved by pull request 30560
[https://github.com/apache/spark/pull/30560]

> GetMapValueUtil code generation error
> -------------------------------------
>
>                 Key: SPARK-33619
>                 URL: https://issues.apache.org/jira/browse/SPARK-33619
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 3.1.0
>            Reporter: Leanken.Lin
>            Assignee: Leanken.Lin
>            Priority: Major
>             Fix For: 3.1.0
>
>
> ```
> In -SPARK-33460---
> there is a bug as follow.
> GetMapValueUtil generated code error when ANSI mode is on
>  
> s"""throw new NoSuchElementException("Key " + $eval2 + " does not exist.");"""
> should be 
> s"""throw new java.util.NoSuchElementException("Key " + $eval2 + " does not exist.");"""
>  
> But Why are
> checkExceptionInExpression[Exception](expr, errMsg)
> and sql/testOnly org.apache.spark.sql.SQLQueryTestSuite – -z ansi/map.sql
> can't detect this Bug
>  
> it's because 
> 1. checkExceptionInExpression is some what error, too. it should wrap with 
> withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key like CheckEvalulation, AND WE SHOULD FIX this later.
> 2. SQLQueryTestSuite ansi/map.sql failed to detect because of the ConstantFolding rules, it is calling eval instead of code gen  in this case
>  
> ```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org