You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/06/26 14:15:41 UTC

[GitHub] spark pull request #21644: [SPARK-24660][SHS] Show correct error pages when ...

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/21644

    [SPARK-24660][SHS] Show correct error pages when downloading logs

    ## What changes were proposed in this pull request?
    
    SHS is showing bad errors when trying to download logs is not successful. This may happen because the requested application doesn't exist or the user doesn't have permissions for it, for instance.
    
    The PR fixes the response when errors occur, so that they are displayed properly.
    
    ## How was this patch tested?
    
    manual tests
    
    **Before the patch:**
     1. Unauthorized user
    ![screen shot 2018-06-26 at 3 53 33 pm](https://user-images.githubusercontent.com/8821783/41918118-f8b37e70-795b-11e8-91e8-d0250239f09d.png)
    
     2. Non-existing application
    ![screen shot 2018-06-26 at 3 25 19 pm](https://user-images.githubusercontent.com/8821783/41918082-e3034c72-795b-11e8-970e-cee4a1eae77f.png)
    
    **After the patch** 
     1. Unauthorized user
    ![screen shot 2018-06-26 at 3 41 29 pm](https://user-images.githubusercontent.com/8821783/41918155-0d950476-795c-11e8-8d26-7b7ce73e6fe1.png)
    
     2. Non-existing application
    ![screen shot 2018-06-26 at 3 40 37 pm](https://user-images.githubusercontent.com/8821783/41918175-1a14bb88-795c-11e8-91ab-eadf29190a02.png)
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-24660

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21644
    
----
commit 8b26a5359e9d759668d6608ebf13952d4fa088c7
Author: Marco Gaido <ma...@...>
Date:   2018-06-26T14:01:28Z

    [SPARK-24660][SHS] Show correct error pages when downloading logs

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #21644: [SPARK-24660][SHS] Show correct error pages when ...

Posted by mgaido91 <gi...@git.apache.org>.

Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21644#discussion_r198585141
  
    --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala ---
    @@ -140,11 +140,9 @@ private[v1] class AbstractApplicationResource extends BaseAppResource {
             .header("Content-Type", MediaType.APPLICATION_OCTET_STREAM)
             .build()
         } catch {
    -      case NonFatal(e) =>
    -        Response.serverError()
    -          .entity(s"Event logs are not available for app: $appId.")
    -          .status(Response.Status.SERVICE_UNAVAILABLE)
    -          .build()
    +      case NonFatal(_) =>
    +        UIUtils.buildErrorResponse(Response.Status.SERVICE_UNAVAILABLE,
    --- End diff --
    
    no, we need to set the type, otherwise it returns the response as octet-stream which is causing the issue..


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92392/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/516/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    **[Test build #92392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92392/testReport)** for PR 21644 at commit [`0c6bbbc`](https://github.com/apache/spark/commit/0c6bbbc2d20efe4ac2a954183f91d0eb95f7b757).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/521/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21644
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92384/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org