You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/06/14 08:24:48 UTC
[GitHub] [rocketmq] victorhujt opened a new pull request #2093: optimize code
victorhujt opened a new pull request #2093:
URL: https://github.com/apache/rocketmq/pull/2093
## What is the purpose of the change
more concise for code
## Brief changelog
more concise for code
## Verifying this change
only replace with Math.min()
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] victorhujt commented on pull request #2093: optimize code
Posted by GitBox <gi...@apache.org>.
victorhujt commented on pull request #2093:
URL: https://github.com/apache/rocketmq/pull/2093#issuecomment-643735452
replace with Math.min()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2093: optimize code
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2093:
URL: https://github.com/apache/rocketmq/pull/2093#issuecomment-651749841
This pull request seems to have no major effect, so I will close it.
If you have any questions, you can resubmit the pull request. But Plz pay attention to the following points:
Firstly, plz submit related issues to link this PR and explain the purpose of PR according to the format.
Second, you need to change the target branch to develop.
Finally, plz name the pull request in the correct format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed pull request #2093: optimize code
Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #2093:
URL: https://github.com/apache/rocketmq/pull/2093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2093: optimize code
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2093:
URL: https://github.com/apache/rocketmq/pull/2093#issuecomment-643737157
[](https://coveralls.io/builds/31439517)
Coverage increased (+0.02%) to 50.869% when pulling **48571076709776dd21d528d202f3660c47f94b2a on victorhujt:master** into **e923a35393a6dfa83677335e96fdb4b063f10d32 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2093: optimize code
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2093:
URL: https://github.com/apache/rocketmq/pull/2093#issuecomment-643737157
[](https://coveralls.io/builds/31441222)
Coverage decreased (-0.05%) to 50.802% when pulling **818ceb2f575c316c2a1c3f1b8319ae78870a9c5d on victorhujt:master** into **e923a35393a6dfa83677335e96fdb4b063f10d32 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org