You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by ni...@apache.org on 2011/11/09 13:48:13 UTC

svn commit: r1199722 - in /camel/branches/camel-2.8.x: ./ components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/ components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/

Author: ningjiang
Date: Wed Nov  9 12:48:12 2011
New Revision: 1199722

URL: http://svn.apache.org/viewvc?rev=1199722&view=rev
Log:
Merged revisions 1199654 via svnmerge from 
https://svn.apache.org/repos/asf/camel/trunk

........
  r1199654 | ningjiang | 2011-11-09 16:47:32 +0800 (Wed, 09 Nov 2011) | 1 line
  
  CAMEL-4648 Clean up the code of CxfRsEndpoint of getting configuration from spring or blueprint
........

Modified:
    camel/branches/camel-2.8.x/   (props changed)
    camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsClientBlueprintBean.java
    camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsServerBlueprintBean.java
    camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsBlueprintEndpoint.java
    camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsSpringEndpoint.java

Propchange: camel/branches/camel-2.8.x/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Nov  9 12:48:12 2011
@@ -1 +1 @@
-/camel/trunk:1186106,1186625,1186772,1187221,1187485,1187882,1187893,1188070-1188085,1188642,1188674,1188879,1188881,1189139,1189600,1189681,1189693,1189737,1190212-1190213,1190246,1190303,1195317,1195616,1196210,1197450,1197933,1197948,1198199,1198338,1198340,1199123,1199137,1199683
+/camel/trunk:1186106,1186625,1186772,1187221,1187485,1187882,1187893,1188070-1188085,1188642,1188674,1188879,1188881,1189139,1189600,1189681,1189693,1189737,1190212-1190213,1190246,1190303,1195317,1195616,1196210,1197450,1197933,1197948,1198199,1198338,1198340,1199123,1199137,1199654,1199683

Propchange: camel/branches/camel-2.8.x/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.

Modified: camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsClientBlueprintBean.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsClientBlueprintBean.java?rev=1199722&r1=1199721&r2=1199722&view=diff
==============================================================================
--- camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsClientBlueprintBean.java (original)
+++ camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsClientBlueprintBean.java Wed Nov  9 12:48:12 2011
@@ -40,13 +40,5 @@ public class RsClientBlueprintBean exten
     public void setBundleContext(BundleContext bundleContext) {
         this.bundleContext = bundleContext;
     }
-   
-    public RsClientBlueprintBean copy() {
-        try {
-            return (RsClientBlueprintBean) clone();
-        } catch (CloneNotSupportedException e) {
-            throw new RuntimeCamelException(e);
-        }
-    }
 
 }

Modified: camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsServerBlueprintBean.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsServerBlueprintBean.java?rev=1199722&r1=1199721&r2=1199722&view=diff
==============================================================================
--- camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsServerBlueprintBean.java (original)
+++ camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/blueprint/RsServerBlueprintBean.java Wed Nov  9 12:48:12 2011
@@ -42,12 +42,4 @@ public class RsServerBlueprintBean exten
         this.bundleContext = bundleContext;
     }
     
-    public RsServerBlueprintBean copy() {
-        try {
-            return (RsServerBlueprintBean) clone();
-        } catch (CloneNotSupportedException e) {
-            throw new RuntimeCamelException(e);
-        }
-    }
-
 }

Modified: camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsBlueprintEndpoint.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsBlueprintEndpoint.java?rev=1199722&r1=1199721&r2=1199722&view=diff
==============================================================================
--- camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsBlueprintEndpoint.java (original)
+++ camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsBlueprintEndpoint.java Wed Nov  9 12:48:12 2011
@@ -68,13 +68,13 @@ public class CxfRsBlueprintEndpoint exte
     @Override
     protected JAXRSServerFactoryBean newJAXRSServerFactoryBean() {
         checkBeanType(bean, JAXRSServerFactoryBean.class);
-        return ((RsServerBlueprintBean)bean).copy();
+        return (RsServerBlueprintBean)bean;
     }
     
     @Override
     protected JAXRSClientFactoryBean newJAXRSClientFactoryBean() {
         checkBeanType(bean, JAXRSClientFactoryBean.class);
-        return ((RsClientBlueprintBean)bean).copy();
+        return (RsClientBlueprintBean)bean;
     }
     
 

Modified: camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsSpringEndpoint.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsSpringEndpoint.java?rev=1199722&r1=1199721&r2=1199722&view=diff
==============================================================================
--- camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsSpringEndpoint.java (original)
+++ camel/branches/camel-2.8.x/components/camel-cxf/src/main/java/org/apache/camel/component/cxf/jaxrs/CxfRsSpringEndpoint.java Wed Nov  9 12:48:12 2011
@@ -30,9 +30,8 @@ import org.springframework.context.suppo
 
 public class CxfRsSpringEndpoint extends CxfRsEndpoint implements BeanIdAware {
     private AbstractJAXRSFactoryBean bean;
-    private ApplicationContext applicationContext;
     private String beanId;
-    private ConfigurerImpl configurer;
+    
     
     public CxfRsSpringEndpoint(CamelContext context, AbstractJAXRSFactoryBean bean) throws Exception {
         super(bean.getAddress(), context);        
@@ -44,35 +43,15 @@ public class CxfRsSpringEndpoint extends
         if (bean instanceof BeanIdAware) {
             setBeanId(((BeanIdAware)bean).getBeanId());
         }
-        applicationContext = ((SpringCamelContext)getCamelContext()).getApplicationContext();
-        // create configurer
-        configurer = new ConfigurerImpl(applicationContext);
     }
     
-    void configure(Object beanInstance) {
-        // check the ApplicationContext states first , and call the refresh if necessary
-        if (applicationContext instanceof AbstractApplicationContext) {
-            AbstractApplicationContext context = (AbstractApplicationContext) applicationContext;
-            if (!context.isActive()) {
-                context.refresh();
-            }
-        }
-        configurer.configureBean(beanId, beanInstance);
-    }
-    
-    
-    
     @Override
     protected void setupJAXRSServerFactoryBean(JAXRSServerFactoryBean sfb) {
-        checkBeanType(bean, JAXRSServerFactoryBean.class);
-        configure(sfb);
-        
+        // Do nothing here
     }
     
     @Override
     protected void setupJAXRSClientFactoryBean(JAXRSClientFactoryBean cfb, String address) {
-        checkBeanType(bean, JAXRSClientFactoryBean.class);
-        configure(cfb);      
         cfb.setAddress(address);
         // Need to enable the option of ThreadSafe
         cfb.setThreadSafe(true);
@@ -80,12 +59,14 @@ public class CxfRsSpringEndpoint extends
     
     @Override
     protected JAXRSServerFactoryBean newJAXRSServerFactoryBean() {
-        return new SpringJAXRSServerFactoryBean();
+        checkBeanType(bean, JAXRSServerFactoryBean.class);
+        return (JAXRSServerFactoryBean)bean;
     }
     
     @Override
     protected JAXRSClientFactoryBean newJAXRSClientFactoryBean() {
-        return new SpringJAXRSClientFactoryBean();
+        checkBeanType(bean, JAXRSClientFactoryBean.class);
+        return (JAXRSClientFactoryBean)bean;
     }
     
     public String getBeanId() {