You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/10 12:07:58 UTC
Review Request 57507: Diff tool shows additional line when comparing
configs from custom config group
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/
-----------------------------------------------------------
Review request for Ambari and Jaimin Jetly.
Bugs: ambari-20388
https://issues.apache.org/jira/browse/ambari-20388
Repository: ambari
Description
-------
- Create a custom config group for a service
- Update few properties and save to get a version for this custom group
- Add another property and save just to generate more config version
- Compare these 2 versions. Usually diff shows only the values from compared versions
- But looks like it shows the current value and the values in each version as well.
- In default group we dont see that extra line with the current value.
Diffs
-----
ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
Diff: https://reviews.apache.org/r/57507/diff/1/
Testing
-------
20559 passing (23s)
153 pending
Thanks,
Oleg Nechiporenko
Re: Review Request 57507: Diff tool shows additional line when
comparing configs from custom config group
Posted by Oleg Nechiporenko <on...@apache.org>.
> On March 16, 2017, 8:26 p.m., Jaimin Jetly wrote:
> > If there is no UX impact and patch has been tested to work e2e then please commit it.
This patch just fix an issue with some "unknown" field that appears when two version of not default config group are compared. IDK what UX impact it may do.
- Oleg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/#review169207
-----------------------------------------------------------
On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57507/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 12:49 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: ambari-20388
> https://issues.apache.org/jira/browse/ambari-20388
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Create a custom config group for a service
> - Update few properties and save to get a version for this custom group
> - Add another property and save just to generate more config version
> - Compare these 2 versions. Usually diff shows only the values from compared versions
> - But looks like it shows the current value and the values in each version as well.
> - In default group we dont see that extra line with the current value.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 786c6f9
> ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4
> ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
> ambari-web/app/views/common/controls_view.js 4bd4a61
>
>
> Diff: https://reviews.apache.org/r/57507/diff/2/
>
>
> Testing
> -------
>
> 20559 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57507: Diff tool shows additional line when
comparing configs from custom config group
Posted by Jaimin Jetly <ja...@hortonworks.com>.
> On March 16, 2017, 8:26 p.m., Jaimin Jetly wrote:
> > If there is no UX impact and patch has been tested to work e2e then please commit it.
>
> Oleg Nechiporenko wrote:
> This patch just fix an issue with some "unknown" field that appears when two version of not default config group are compared. IDK what UX impact it may do.
ok. That seems good. Please go ahead and commit the patch
- Jaimin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/#review169207
-----------------------------------------------------------
On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57507/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 12:49 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: ambari-20388
> https://issues.apache.org/jira/browse/ambari-20388
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Create a custom config group for a service
> - Update few properties and save to get a version for this custom group
> - Add another property and save just to generate more config version
> - Compare these 2 versions. Usually diff shows only the values from compared versions
> - But looks like it shows the current value and the values in each version as well.
> - In default group we dont see that extra line with the current value.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 786c6f9
> ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4
> ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
> ambari-web/app/views/common/controls_view.js 4bd4a61
>
>
> Diff: https://reviews.apache.org/r/57507/diff/2/
>
>
> Testing
> -------
>
> 20559 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57507: Diff tool shows additional line when
comparing configs from custom config group
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/#review169207
-----------------------------------------------------------
Ship it!
If there is no UX impact and patch has been tested to work e2e then please commit it.
- Jaimin Jetly
On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57507/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 12:49 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: ambari-20388
> https://issues.apache.org/jira/browse/ambari-20388
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Create a custom config group for a service
> - Update few properties and save to get a version for this custom group
> - Add another property and save just to generate more config version
> - Compare these 2 versions. Usually diff shows only the values from compared versions
> - But looks like it shows the current value and the values in each version as well.
> - In default group we dont see that extra line with the current value.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 786c6f9
> ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4
> ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
> ambari-web/app/views/common/controls_view.js 4bd4a61
>
>
> Diff: https://reviews.apache.org/r/57507/diff/2/
>
>
> Testing
> -------
>
> 20559 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57507: Diff tool shows additional line when
comparing configs from custom config group
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/#review169303
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57507/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 12:49 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: ambari-20388
> https://issues.apache.org/jira/browse/ambari-20388
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Create a custom config group for a service
> - Update few properties and save to get a version for this custom group
> - Add another property and save just to generate more config version
> - Compare these 2 versions. Usually diff shows only the values from compared versions
> - But looks like it shows the current value and the values in each version as well.
> - In default group we dont see that extra line with the current value.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 786c6f9
> ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4
> ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
> ambari-web/app/views/common/controls_view.js 4bd4a61
>
>
> Diff: https://reviews.apache.org/r/57507/diff/2/
>
>
> Testing
> -------
>
> 20559 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57507: Diff tool shows additional line when
comparing configs from custom config group
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/#review169206
-----------------------------------------------------------
ambari-web/app/mixins/common/configs/configs_comparator.js
Lines 290-295 (original), 290-297 (patched)
<https://reviews.apache.org/r/57507/#comment241545>
will this have any UX impact ?
- Jaimin Jetly
On March 16, 2017, 12:49 p.m., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57507/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 12:49 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: ambari-20388
> https://issues.apache.org/jira/browse/ambari-20388
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Create a custom config group for a service
> - Update few properties and save to get a version for this custom group
> - Add another property and save just to generate more config version
> - Compare these 2 versions. Usually diff shows only the values from compared versions
> - But looks like it shows the current value and the values in each version as well.
> - In default group we dont see that extra line with the current value.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 786c6f9
> ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4
> ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
> ambari-web/app/views/common/controls_view.js 4bd4a61
>
>
> Diff: https://reviews.apache.org/r/57507/diff/2/
>
>
> Testing
> -------
>
> 20559 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 57507: Diff tool shows additional line when
comparing configs from custom config group
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57507/
-----------------------------------------------------------
(Updated March 16, 2017, 12:49 p.m.)
Review request for Ambari and Jaimin Jetly.
Changes
-------
Extra patch added
Bugs: ambari-20388
https://issues.apache.org/jira/browse/ambari-20388
Repository: ambari
Description
-------
- Create a custom config group for a service
- Update few properties and save to get a version for this custom group
- Add another property and save just to generate more config version
- Compare these 2 versions. Usually diff shows only the values from compared versions
- But looks like it shows the current value and the values in each version as well.
- In default group we dont see that extra line with the current value.
Diffs (updated)
-----
ambari-web/app/controllers/main/service/info/configs.js 786c6f9
ambari-web/app/mixins/common/configs/configs_comparator.js d4551b4
ambari-web/app/templates/common/configs/service_config_category.hbs 9890525
ambari-web/app/views/common/controls_view.js 4bd4a61
Diff: https://reviews.apache.org/r/57507/diff/2/
Changes: https://reviews.apache.org/r/57507/diff/1-2/
Testing
-------
20559 passing (23s)
153 pending
Thanks,
Oleg Nechiporenko