You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2023/06/05 22:18:45 UTC

[GitHub] [tinkerpop] Cole-Greer commented on pull request #2004: Adds Missing .glv file warnings to maven

Cole-Greer commented on PR #2004:
URL: https://github.com/apache/tinkerpop/pull/2004#issuecomment-1577557867

   > I'm slightly on the fence about this one. It'll be great to have warnings which tells you that you aren't building the GLVs, but I'm not sure if it's necessarily worth adding an entire profile for each of the GLVs for this, given that there is documentation about them, and also we are considering removing the need to use `.glv` in 3.7.0 (as they were initially added due to GLV tests required environment set-up, but we are now using Docker which should be able to remove that need). Would there be an easier way to add the warning in an existing profile?
   
   This was the best method for adding some sort of warning that I could find. It is possible there are better solutions but I don't think it's worth investing much time in. I think this warning would be helpful for current developers, we can remove these profiles once the `.glv` system is torn out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org