[GitHub] [spark] attilapiros commented on issue #24565: [SPARK-27665][Core] Split fetch shuffle blocks protocol from OpenBlocks

[GitBox <gi...@apache.org>]

attilapiros commented on issue #24565: [SPARK-27665][Core] Split fetch shuffle blocks protocol from OpenBlocks
URL: https://github.com/apache/spark/pull/24565#issuecomment-493518805
 
 
   @squito I think the best would be to introduce a new message for asking the version of the running shuffle service and making the decision based on that version. 
   
   But if we would like to support 2.4 too without modify it (and adding this new message backward) then besides this new message we should introduce a new config parameter too for the shuffle service version (in Spark) and when its value is greater equal where the version message is available we can use the message to find the exact version.
   
   Question: should we do that in one of these PRs or separately? (I would be happy to work on it just let's decided where we want it and avoid parallel work).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org