[GitHub] DaanHoogland commented on a change in pull request #2420: CLOUDSTACK-10247: L2 network not shared on projects

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2420: CLOUDSTACK-10247: L2 network not shared on projects
URL: https://github.com/apache/cloudstack/pull/2420#discussion_r163479947
 
 

 ##########
 File path: server/src/com/cloud/network/NetworkModelImpl.java
 ##########
 @@ -1637,7 +1637,8 @@ public void checkNetworkPermissions(Account owner, Network network) {
             throw new CloudRuntimeException("cannot check permissions on (Network) <null>");
         }
         // Perform account permission check
-        if (network.getGuestType() != Network.GuestType.Shared || (network.getGuestType() == Network.GuestType.Shared && network.getAclType() == ACLType.Account)) {
+        if ((network.getGuestType() != Network.GuestType.Shared && network.getGuestType() != GuestType.L2) ||
 
 Review comment:
   Network.GuestType.Shared is used and then GuestType.L2 directly. please cleanup the imports and use only one scope for one java class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services