You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/06/29 11:27:54 UTC

[GitHub] zeppelin pull request #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to set...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2451

    [ZEPPELIN-2708][DOCS] feat: Add v scroll to setup, usage menus in navbar

    ### What is this PR for?
    
    Added v scroll to setup, usage menus in the navbar.
    Because some users are experiencing trimmed menus (not sure exact OS, browser versions, See the JIRA issue)
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2708](https://issues.apache.org/jira/browse/ZEPPELIN-2708)
    
    ### How should this be tested?
    
    1. cd `docs/`
    2. run: `bundle exec jekyll serve --watch`
    
    
    
    ### Screenshots (if appropriate)
    
    #### Before (no scrollbar)
    
    ![image](https://user-images.githubusercontent.com/4968473/27685495-5bedcba0-5d09-11e7-8e7b-76d15c407626.png)
    
    #### After
    
    ![image](https://user-images.githubusercontent.com/4968473/27685496-6032193c-5d09-11e7-88bc-dc0a2a44398b.png)
    
    ![image](https://user-images.githubusercontent.com/4968473/27685505-64e7a802-5d09-11e7-91df-17b66cabc147.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2708/provide-V-scrolls-for-navbar-menus

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2451
    
----
commit fb322b21e861ec2cd361f593fc7a824268754643
Author: 1ambda <1a...@gmail.com>
Date:   2017-06-29T11:24:38Z

    feat: Add v scroll to setup, usage menus

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to setup, usa...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2451
  
    @tae-jun Thanks for the quick review!
    
    Merge if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to setup, usa...

Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:

    https://github.com/apache/zeppelin/pull/2451
  
    Now it works perfectly 👍 
    LGTM!
    
    ![image](https://user-images.githubusercontent.com/8201019/27687030-32daeb38-5d10-11e7-8b20-8c4f350947dc.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to setup, usa...

Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:

    https://github.com/apache/zeppelin/pull/2451
  
    Cool! it looks better than before. LGTM
    ![image](https://user-images.githubusercontent.com/8110458/27707690-2db383a4-5d51-11e7-9b55-54fc48525e55.png)
    ![image](https://user-images.githubusercontent.com/8110458/27707716-4adcb928-5d51-11e7-9353-113c4fa51b9b.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to set...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2451


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---