You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by bh...@apache.org on 2019/08/28 21:59:56 UTC
[hadoop] branch trunk updated: HDDS-1941. Unused executor in
SimpleContainerDownloader (#1367)
This is an automated email from the ASF dual-hosted git repository.
bharat pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/trunk by this push:
new 872cdf4 HDDS-1941. Unused executor in SimpleContainerDownloader (#1367)
872cdf4 is described below
commit 872cdf48a638236441669ca6fa4d4077c39370aa
Author: Doroszlai, Attila <64...@users.noreply.github.com>
AuthorDate: Wed Aug 28 23:59:49 2019 +0200
HDDS-1941. Unused executor in SimpleContainerDownloader (#1367)
---
.../replication/SimpleContainerDownloader.java | 22 ++--------------------
1 file changed, 2 insertions(+), 20 deletions(-)
diff --git a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/SimpleContainerDownloader.java b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/SimpleContainerDownloader.java
index 032dc7d..37a44ac 100644
--- a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/SimpleContainerDownloader.java
+++ b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/SimpleContainerDownloader.java
@@ -18,15 +18,10 @@
package org.apache.hadoop.ozone.container.replication;
-import java.io.IOException;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;
import java.util.concurrent.CompletableFuture;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.ThreadFactory;
-import java.util.concurrent.TimeUnit;
import java.util.function.Function;
import org.apache.hadoop.conf.Configuration;
@@ -34,7 +29,6 @@ import org.apache.hadoop.hdds.protocol.DatanodeDetails;
import org.apache.hadoop.hdds.protocol.DatanodeDetails.Port.Name;
import org.apache.hadoop.ozone.OzoneConfigKeys;
-import com.google.common.util.concurrent.ThreadFactoryBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -52,8 +46,6 @@ public class SimpleContainerDownloader implements ContainerDownloader {
private final Path workingDirectory;
- private ExecutorService executor;
-
public SimpleContainerDownloader(Configuration conf) {
String workDirString =
@@ -65,12 +57,6 @@ public class SimpleContainerDownloader implements ContainerDownloader {
} else {
workingDirectory = Paths.get(workDirString);
}
-
- ThreadFactory build = new ThreadFactoryBuilder().setDaemon(true)
- .setNameFormat("Container downloader thread - %d").build();
- executor = Executors.newSingleThreadExecutor(build);
- LOG.info("Starting container downloader service to copy "
- + "containers to replicate.");
}
@Override
@@ -110,11 +96,7 @@ public class SimpleContainerDownloader implements ContainerDownloader {
}
@Override
- public void close() throws IOException {
- try {
- executor.awaitTermination(10, TimeUnit.SECONDS);
- } catch (InterruptedException e) {
- LOG.error("Can't stop container downloader gracefully", e);
- }
+ public void close() {
+ // noop
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org