You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/09 03:45:27 UTC

[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1576: [#1573]1.5 fix the nacos namespace from server/client.yml does not take e…

Mulavar commented on a change in pull request #1576:
URL: https://github.com/apache/dubbo-go/pull/1576#discussion_r745266895



##########
File path: config_center/dynamic_configuration.go
##########
@@ -34,10 +34,10 @@ import (
 // DynamicConfiguration
 // ////////////////////////////////////////
 const (
-	// DEFAULT_GROUP: default group
+	// DEFAULT_GROUP default group

Review comment:
       不删除原有常量是发现有其他地方在用（apollo、file），尚不清楚这两个的具体实现，因此为了避免歧义新增了常量。




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org