You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/17 08:58:30 UTC
[GitHub] [flink] jinglining opened a new pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
jinglining opened a new pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882
[hotfix][rest]Fix initialize webSubmissionHandlers list in WebSubmissionExtension with correct size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] jinglining commented on a change in pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
jinglining commented on a change in pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#discussion_r367853887
##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebSubmissionExtension.java
##########
@@ -61,7 +61,7 @@ public WebSubmissionExtension(
Executor executor,
Time timeout) throws Exception {
- webSubmissionHandlers = new ArrayList<>(5);
+ webSubmissionHandlers = new ArrayList<>(6);
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-575543343
<!--
Meta data
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144902129 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
-->
## CI report:
* 849307860f3eb15373f65cb50926ed3f971f4834 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144902129) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-575543343
<!--
Meta data
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144902129 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:b30ca851d66f95b011dcce70084ce6fdd9286434 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144911909 TriggerType:PUSH TriggerID:b30ca851d66f95b011dcce70084ce6fdd9286434
Hash:b30ca851d66f95b011dcce70084ce6fdd9286434 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4433 TriggerType:PUSH TriggerID:b30ca851d66f95b011dcce70084ce6fdd9286434
-->
## CI report:
* 849307860f3eb15373f65cb50926ed3f971f4834 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144902129) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428)
* b30ca851d66f95b011dcce70084ce6fdd9286434 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144911909) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#discussion_r367831834
##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebSubmissionExtension.java
##########
@@ -61,7 +61,7 @@ public WebSubmissionExtension(
Executor executor,
Time timeout) throws Exception {
- webSubmissionHandlers = new ArrayList<>(5);
+ webSubmissionHandlers = new ArrayList<>(6);
Review comment:
I think the following rule applies here. I would suggest to get rid of the capacity altogether.
> Set the initial capacity for a collection only if there is a good proven reason for that, otherwise do not clutter the code. In case of Maps it can be even deluding because the Map’s load factor effectively reduces the capacity.
https://flink.apache.org/contributing/code-style-and-quality-java.html#collections
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-575537190
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 849307860f3eb15373f65cb50926ed3f971f4834 (Fri Jan 17 09:01:30 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15628).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-575543343
<!--
Meta data
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144902129 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:b30ca851d66f95b011dcce70084ce6fdd9286434 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b30ca851d66f95b011dcce70084ce6fdd9286434
-->
## CI report:
* 849307860f3eb15373f65cb50926ed3f971f4834 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144902129) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428)
* b30ca851d66f95b011dcce70084ce6fdd9286434 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-575543343
<!--
Meta data
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
-->
## CI report:
* 849307860f3eb15373f65cb50926ed3f971f4834 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-578493975
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882#issuecomment-575543343
<!--
Meta data
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/144902129 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:849307860f3eb15373f65cb50926ed3f971f4834 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428 TriggerType:PUSH TriggerID:849307860f3eb15373f65cb50926ed3f971f4834
Hash:b30ca851d66f95b011dcce70084ce6fdd9286434 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144911909 TriggerType:PUSH TriggerID:b30ca851d66f95b011dcce70084ce6fdd9286434
Hash:b30ca851d66f95b011dcce70084ce6fdd9286434 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4433 TriggerType:PUSH TriggerID:b30ca851d66f95b011dcce70084ce6fdd9286434
-->
## CI report:
* 849307860f3eb15373f65cb50926ed3f971f4834 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/144902129) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4428)
* b30ca851d66f95b011dcce70084ce6fdd9286434 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144911909) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4433)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #10882: [FLINK-15628][rest]Fix initialize webSubmissionHandlers list in WebSu…
URL: https://github.com/apache/flink/pull/10882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services