[jira] [Issue Comment Deleted] (CB-1933) Using comma in button labels

["Ingo Bürk (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CB-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ingo Bürk updated CB-1933:
--------------------------

    Comment: was deleted

(was: I only suggested this a while ago, I don't have a use for it right now. Still, I don't think that is a good way to go because it introduces a discrepancy for the JS interface between the platforms which would require developers to adapt their JS code depending on the platform. That is defeating the purpose of the Cordova project. 

As long as comma-separated strings aren't fully removed, I think the best way would be to allow both an array and a string as a parameter. If a string is passed, it is parsed into an array before being sent to the native plugin part. This is slightly different to your approach in the sense that it won't break existing code on Android/iOS because it allows downward compatibility and keeps the multi-platform support alive (if not using the new format). I hope it's clear what I mean. Unfortunately I don't have the time to work on this myself right now.)
    
> Using comma in button labels
> ----------------------------
>
>                 Key: CB-1933
>                 URL: https://issues.apache.org/jira/browse/CB-1933
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, CordovaJS
>            Reporter: Ingo Bürk
>            Assignee: Max Woghiren
>            Priority: Minor
>
> It's currently not possible to use comma in button labels when creating confirm dialogs. This would be useful for buttons like "Yes, Delete".
> Probably a good idea for implementation would be allowing an array as the buttonLabels argument, e.g.
>  
> {code}navigator.notification.confirm('Alert!', function(){}, function(){}, 'Title', ['Yes, Do It', 'No']);{code}
> For compatibility it shouldn't be a problem to detect whether a string or an array has been passed and act accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira