You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/15 14:58:59 UTC

[GitHub] larroy commented on issue #9397: Remove incorrect link flags when using OPENCV. Add additional library?

larroy commented on issue #9397: Remove incorrect link flags when using OPENCV. Add additional library?
URL: https://github.com/apache/incubator-mxnet/pull/9397#issuecomment-357705984
 
 
   @cjolivier01 thanks for your feedback. I actually went through the trouble of running annotate and contacting the author of the change to see if I was missing something. It's not my intention to be argumentative. I think is clear that linker flags have their place in CMake which is not the compile flags. In the future I will try to improve my PR description to be more explicit about the background of the change. I thought it was clear by the context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services