You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Igor Kryvenko <kr...@gmail.com> on 2018/05/24 19:47:59 UTC

Review Request 67294: HIVE-18453: ACID: Add "CREATE TRANSACTIONAL TABLE" syntax to unify ACID ORC & Parquet support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67294/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan, Eugene Koifman, and Vineet Garg.


Bugs: HIVE-18453
    https://issues.apache.org/jira/browse/HIVE-18453


Repository: hive-git


Description
-------

The ACID table markers are currently done with TBLPROPERTIES which is inherently fragile.

The "create transactional table" offers a way to standardize the syntax and allows for future compatibility changes to support Parquet ACIDv2 tables along with ORC tables.

The ACIDv2 design is format independent, with the ability to add new vectorized input formats with no changes to the design.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 09a4368 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8726974 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 55bd92d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 7ff7e18 
  ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java 3e2784b 
  ql/src/test/queries/clientnegative/create_external_transactional.q PRE-CREATION 
  ql/src/test/queries/clientpositive/create_1.q f348e59 
  ql/src/test/queries/clientpositive/create_transactional.q PRE-CREATION 
  ql/src/test/results/clientnegative/create_external_transactional.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/create_transactional.q.out PRE-CREATION 


Diff: https://reviews.apache.org/r/67294/diff/1/


Testing
-------


Thanks,

Igor Kryvenko