You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2016/12/20 07:36:04 UTC

[kudu-CR] [jepsen.kudu] run tests from clojure-maven-plugin

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5551

Change subject: [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

[jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
A build-support/jenkins/jepsen-test.sh
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
7 files changed, 206 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................


Patch Set 7:

(1 comment)

Thank you for the review!  I'll address the comments a little bit later.

http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/README.md
File java/kudu-jepsen/README.md:

Line 16: Note that commas (not spaces) are used to separate the names of the machines.
> Would it be possible to let the shell expand the node list? For example:
I'm not sure that's possible: the issue here is with passing those parameters into maven plugin if those parameters are separated by space (even without any expansion).  In other words, having -DtserverNodes="a b c" in command line does not work.

Of course, it would be nice to fix that, but I'm not sure that's the thing we want to spend our time.  However, if the workaround exists, we could try to use it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5551/2/build-support/jenkins/jepsen-test.sh
File build-support/jenkins/jepsen-test.sh:

> It seems this file got into wrong patchset -- please don't spend time revie
Instead, please take a look at the rest of the files in this patchset -- clojure files and pom.xml.


-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change.

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................


Abandoned

Merged into a single patch: https://gerrit.cloudera.org/#/c/5500

-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5551

to look at the new patch set (#3).

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

WIP [jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
A build-support/jenkins/jepsen-test.sh
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
M java/pom.xml
11 files changed, 571 insertions(+), 234 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

WIP [jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
A build-support/jenkins/jepsen-test.sh
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
7 files changed, 206 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5551/2/build-support/jenkins/jepsen-test.sh
File build-support/jenkins/jepsen-test.sh:

It seems this file got into wrong patchset -- please don't spend time reviewing it in here because it will be done and sent for review in another patchset.


-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5551

to look at the new patch set (#5).

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

WIP [jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
A build-support/jenkins/jepsen-test.sh
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
M java/pom.xml
11 files changed, 698 insertions(+), 252 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/5
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5551

to look at the new patch set (#7).

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

WIP [jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
M java/pom.xml
10 files changed, 656 insertions(+), 253 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/7
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5551

to look at the new patch set (#6).

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

WIP [jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
A build-support/jenkins/jepsen-test.sh
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
M java/pom.xml
11 files changed, 721 insertions(+), 253 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/6
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5551

to look at the new patch set (#4).

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................

WIP [jepsen.kudu] run tests from clojure-maven-plugin

Changes to allow the jepsen Kudu tests to run from the maven plugin
clojure-maven-plugin.  To run the tests on, execute the following
command in the $REPO_ROOT/java/kudu-jepsen directory:
  mvn clojure:run -DmasterNodes=m0 -DtserverNodes="t0 t1 t2 t3 t4"

Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
---
A build-support/jenkins/jepsen-test.sh
M java/kudu-jepsen/.gitignore
M java/kudu-jepsen/README.md
M java/kudu-jepsen/pom.xml
M java/kudu-jepsen/resources/kudu.flags
M java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj
A java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
M java/kudu-jepsen/src/test/clojure/jepsen/kudu_test.clj
A java/kudu-jepsen/src/utils/kudu_test_runner.clj
M java/pom.xml
11 files changed, 571 insertions(+), 234 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/5551/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/.gitignore
File java/kudu-jepsen/.gitignore:

Line 1: .lein-failures
> Could you add comments explaining why we need each one?
Done


http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/README.md
File java/kudu-jepsen/README.md:

Line 22: List of required packages For Debian/Ubuntu machines if us:
> Could you reformat this sentence? It has some grammar issues and multiple c
Done


PS7, Line 23:   krb5-admin-server krb5-kdc krb5-user
            :   libsasl2-modules libsasl2-modules-gssapi-mit lsb-release ntp openssl
> Nit: reformat this into an actual markdown list.
Done.

Actually, I automated that, so this comment and corresponding monkey work is not necessary anymore.


PS7, Line 27: on
> of
Done


http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/pom.xml
File java/kudu-jepsen/pom.xml:

PS7, Line 29:       <masterNodes></masterNodes>
            :       <tserverNodes></tserverNodes>
            :       <sshKeyPath></sshKeyPath>
> Why is this necessary? Aren't all properties empty by default?
I thought it's better to explicitly declare those.

Besides, as it turned out, properties are not empty by default.  At least, when the property is not listed here and used like in <args> element below for clojure-maven-plugin, it is evaluated to "${sshKeyPath}" (!sic).  Since "${sshKeyPath}" is not "", that breaks the test.

I'm going to leave them as is.  If you know the better way to deal with that -- let me know.


Line 102:                 <args>--master-nodes=${masterNodes} --tserver-nodes=${tserverNodes} --ssh-key-path=${sshKeyPath}</args>
> Nit: could you separate each argument on its own line so this is more reada
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
......................................................................


Patch Set 7:

(7 comments)

It's a little tricky navigating across these patches. You might consider squashing them all together to review/merge, unless David or someone else has a lot of context on the first patch or two and would prefer to see just the delta since then.

http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/.gitignore
File java/kudu-jepsen/.gitignore:

Line 1: .lein-failures
Could you add comments explaining why we need each one?


http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/README.md
File java/kudu-jepsen/README.md:

Line 16: Note that commas (not spaces) are used to separate the names of the machines.
Would it be possible to let the shell expand the node list? For example:

  mvn clojure:run -DtserverNodes="t{0..4}" -DmasterNodes="m0"


Line 22: List of required packages For Debian/Ubuntu machines if us:
Could you reformat this sentence? It has some grammar issues and multiple capital letters.


PS7, Line 23:   krb5-admin-server krb5-kdc krb5-user
            :   libsasl2-modules libsasl2-modules-gssapi-mit lsb-release ntp openssl
Nit: reformat this into an actual markdown list.


PS7, Line 27: on
of


http://gerrit.cloudera.org:8080/#/c/5551/7/java/kudu-jepsen/pom.xml
File java/kudu-jepsen/pom.xml:

PS7, Line 29:       <masterNodes></masterNodes>
            :       <tserverNodes></tserverNodes>
            :       <sshKeyPath></sshKeyPath>
Why is this necessary? Aren't all properties empty by default?


Line 102:                 <args>--master-nodes=${masterNodes} --tserver-nodes=${tserverNodes} --ssh-key-path=${sshKeyPath}</args>
Nit: could you separate each argument on its own line so this is more readable?


-- 
To view, visit http://gerrit.cloudera.org:8080/5551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5adb6968df46954f94c11f29ecc4dd4ea56544b1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes