You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/01/31 20:46:10 UTC

[Bug 124160] New: Compiler error

https://issues.apache.org/ooo/show_bug.cgi?id=124160

            Bug ID: 124160
        Issue Type: DEFECT
           Summary: Compiler error
           Product: General
           Version: 4.1.0-dev
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: code
          Assignee: issues@openoffice.apache.org
          Reporter: tkralphs@gmail.com
                CC: issues@openoffice.apache.org

I don't really understand exactly what component is being built when this
compiler error occurs, but I figured out how to fix it just by grepping a bit. 

The error is as follows:

/Users/ted/AOO400/main/vcl/aqua/source/gdi/salprn.cxx:80:38: error: cannot
initialize a parameter of type 'NSPaperOrientation' with an rvalue of type
'<anonymous enum at
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPrintInfo.h:213:1>'
        [mpPrintInfo setOrientation: NSPortraitOrientation];
                                     ^~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPrintInfo.h:102:44:
note: passing argument to parameter 'orientation' here
- (void)setOrientation:(NSPaperOrientation)orientation;

Changing NSPortraitOrientation to NSPaperOrientationPortrait seems to fix the
issue. I grepped around for strings in other places in the code and found the
latter in some other places, though I don't really understand the full picture.
I did manage to build a complete working version of Open Office with this
change, though. Patch is attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

Edwin Sharp <el...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |elish@apache.org
     Ever confirmed|0                           |1

--- Comment #4 from Edwin Sharp <el...@apache.org> ---
Confirmed per comment 3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsc@apache.org
           Severity|blocker                     |normal

--- Comment #3 from jsc@apache.org ---
remove the blocker flag to avoid confusion.

We will as soon as possible try to build on a 10.9 system and review the patch.
Thanks a lot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Issue 124160] type mismatch of NSPortraitOrientation in newer OSX SDKs

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

gjaa88@aol.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gjaa88@aol.com              |

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

--- Comment #1 from Ted Ralphs <tk...@gmail.com> ---
Created attachment 82457
  --> https://issues.apache.org/ooo/attachment.cgi?id=82457&action=edit
Patch to fix issue

This patch didn't seem to get properly attached in my original submission.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Issue 124160] type mismatch of NSPortraitOrientation in newer OSX SDKs

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

gjaa88@aol.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gjaa88@aol.com

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

Ted Ralphs <tk...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkralphs@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Issue 124160] type mismatch of NSPortraitOrientation in newer OSX SDKs

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
             Latest|---                         |4.2.0-dev
    Confirmation on|                            |
           Hardware|All                         |Mac
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.2.0

--- Comment #9 from hdu@apache.org <hd...@apache.org> ---
Was fixed in revision 1633297 in issue 125776.

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

--- Comment #7 from jsc@apache.org ---
no I don't think so, it is not critical for 4.1 and we build the official
releases on older systems anyway. 10.9 is not yet officially supported and we
can't guarantee for this platform. It's enough to fix this on trunk for now. We
have other problems on 10.9 to build backward compatible to 10.7, 10.8. This
issue should be solved first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

--- Comment #2 from Ted Ralphs <tk...@gmail.com> ---
By the way, this error is with the svn revision 1563031 (as you see in the
patch), despite the folder name, which indicates an earlier snapshot. I did an
svn switch to a later snapshot because 4.0.0 does not configure properly on OS
X 10.9. It still wants to use gcc 4.0. The latest snapshot seems to be capable
of using clang.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Issue 124160] type mismatch of NSPortraitOrientation in newer OSX SDKs

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

gjaa88@aol.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gjaa88@aol.com

-- 
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com,
                   |                            |hdu@apache.org

--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Adding Herbert to CC

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124160] type mismatch of NSPortraitOrientation in newer OSX SDKs

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Compiler error              |type mismatch of
                   |                            |NSPortraitOrientation in
                   |                            |newer OSX SDKs
                 OS|All                         |Mac OSX, 10.9

--- Comment #8 from hdu@apache.org <hd...@apache.org> ---
According to the NSPrintInfo reference [1] the code looks good even for newer
SDKs.

Does a cast work too? Please change the line to
  [mpPrintInfo setOrientation: (NSPrintingOrientation)NSPortraitOrientation];
and check if this works. NSPaperOrientationPortrait isn't available in SDKs
10.7 and 10.8.

[1]
https://developer.apple.com/library/mac/documentation/cocoa/reference/applicationkit/classes/NSPrintInfo_Class/Reference/Reference.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 124160] Compiler error

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124160

Andrea Pescetti <pe...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |UNCONFIRMED
                 CC|                            |pescetti@apache.org
     Ever confirmed|1                           |0
           Severity|normal                      |blocker

--- Comment #5 from Andrea Pescetti <pe...@apache.org> ---
Shall we review and possibly commit this Mac OS X 10.9 patch before we release
OpenOffice 4.1?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.