You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by gvramana <gi...@git.apache.org> on 2018/02/02 07:12:17 UTC

[GitHub] carbondata pull request #1104: [CARBONDATA-1239] Add validation for set comm...

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1104#discussion_r165571781
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableOutputFormat.java ---
    @@ -307,17 +307,11 @@ public static CarbonLoadModel getLoadModel(Configuration conf) throws IOExceptio
         }
         model.setDateFormat(
             conf.get(
    -            DATE_FORMAT,
    -            carbonProperty.getProperty(
    -                CarbonLoadOptionConstants.CARBON_OPTIONS_DATEFORMAT,
    -                CarbonLoadOptionConstants.CARBON_OPTIONS_DATEFORMAT_DEFAULT)));
    +            DATE_FORMAT, ""));
    --- End diff --
    
    I thinks should take default fimestamp if  not set in conf, please confirm


---