You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/07/31 02:02:00 UTC

[jira] [Work logged] (GOBBLIN-837) refactor FlowConfigV2Client and FlowStatusClient to allow child classes modify respective RequestBuilders

     [ https://issues.apache.org/jira/browse/GOBBLIN-837?focusedWorklogId=285448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285448 ]

ASF GitHub Bot logged work on GOBBLIN-837:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Jul/19 02:01
            Start Date: 31/Jul/19 02:01
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on pull request #2696: [GOBBLIN-837] refactor FlowConfigV2Client and FlowStatusClient to allow child class…
URL: https://github.com/apache/incubator-gobblin/pull/2696
 
 
   …es modify respective RequestBuilders
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @sv2000  please review
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   this is needed to overcome the issue where requestbuilders hard code the base uri path to resource path
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   trivial changes
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 285448)
            Time Spent: 10m
    Remaining Estimate: 0h

> refactor FlowConfigV2Client and FlowStatusClient to allow child classes modify respective RequestBuilders
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-837
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-837
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> so linkedin we can send requests to internal services whose name differ from the open source service name



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)