You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/18 10:55:42 UTC
[GitHub] [commons-text] arturobernalg opened a new pull request #222: TEXT-200 - Simplify statements
arturobernalg opened a new pull request #222:
URL: https://github.com/apache/commons-text/pull/222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] coveralls commented on pull request #222: TEXT-200 - Simplify statements
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #222:
URL: https://github.com/apache/commons-text/pull/222#issuecomment-821973057
[](https://coveralls.io/builds/38911181)
Coverage decreased (-0.001%) to 97.983% when pulling **3db666e47536bd28b2e172c6d8b3632b2b7eb482 on arturobernalg:feature/TEXT-200** into **a55195ee787b7065c9799bde421acf5fd8526621 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] kinow commented on pull request #222: TEXT-200 - Simplify statements
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #222:
URL: https://github.com/apache/commons-text/pull/222#issuecomment-822826015
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] kinow commented on a change in pull request #222: TEXT-200 - Simplify statements
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615449277
##########
File path: src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##########
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws IOException {
- if (codepoint >= Character.MIN_SURROGATE && codepoint <= Character.MAX_SURROGATE) {
- // It's a surrogate. Write nothing and say we've translated.
- return true;
- }
+ // It's a surrogate. Write nothing and say we've translated.
Review comment:
@arturobernalg I think this comment here doesn't relate to the single return statement now (it is, and it is not, true and false now).
Maybe change it to `// If true, it is a surrogate. Write nothing and say we've translated. Otherwise return false, and don't translate it.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] arturobernalg commented on a change in pull request #222: TEXT-200 - Simplify statements
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #222:
URL: https://github.com/apache/commons-text/pull/222#discussion_r615534203
##########
File path: src/main/java/org/apache/commons/text/translate/UnicodeUnpairedSurrogateRemover.java
##########
@@ -31,12 +31,9 @@
*/
@Override
public boolean translate(final int codepoint, final Writer writer) throws IOException {
- if (codepoint >= Character.MIN_SURROGATE && codepoint <= Character.MAX_SURROGATE) {
- // It's a surrogate. Write nothing and say we've translated.
- return true;
- }
+ // It's a surrogate. Write nothing and say we've translated.
Review comment:
Agree. Changed.
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-text] kinow closed pull request #222: TEXT-200 - Simplify statements
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #222:
URL: https://github.com/apache/commons-text/pull/222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org