You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/20 17:57:43 UTC

[GitHub] [hbase] HorizonNet commented on a change in pull request #1743: HBASE-24403 FsDelegationToken should cache token after acquired a new one

HorizonNet commented on a change in pull request #1743:
URL: https://github.com/apache/hbase/pull/1743#discussion_r428202664



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/FsDelegationToken.java
##########
@@ -104,6 +104,7 @@ public void acquireDelegationToken(final String tokenKind, final FileSystem fs)
         hasForwardedToken = false;
         try {
           userToken = fs.getDelegationToken(renewer);
+          userProvider.getCurrent().addToken(userToken);

Review comment:
       LGTM. Does it make sense to add a small test to have it covered/verified?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org