[GitHub] [bookkeeper] StevenLuMT commented on pull request #3796: BP61: revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

["StevenLuMT (via GitHub)" <gi...@apache.org>]

StevenLuMT commented on PR #3796:
URL: https://github.com/apache/bookkeeper/pull/3796#issuecomment-1455476148

   > Fix #3792
   
   why not directly replace ReferenceCountUtil.safeRelease() with ReferenceCountUtil.release?
   #3840
   
   > > https://mail.google.com/mail/u/0/#inbox/FMfcgzGrcjQBvslxtJLpRNJfqCwknmpg -1 (non-binding) for new BP-61 :
   > > 
   > > 1. I think no need to revert 12 PRs to refactor the ByteBuf release method
   > > 2. Directly replace ReferenceCountUtil.safeRelease() with ReferenceCountUtil.release()
   > 
   > @StevenLuMT I just replace `ReferenceCountUtil.safeRelease()` with `ReferenceCountUtil.release()` to revert those changes, would you please point out your ideas in detail?
   
   sorry, I seem to have misunderstood, I thought you reverted first, and then proposed a replacement,
   are your two replacements made for different branches? #3796 #3398 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org