[jira] [Commented] (DRILL-5961) For long running queries (> 10 min) Drill may raise FragmentSetupException for completed/cancelled fragments

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281161#comment-16281161 ] 

ASF GitHub Bot commented on DRILL-5961:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1041#discussion_r155396889
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
    @@ -277,7 +277,9 @@ public void startFragmentPendingRemote(final FragmentManager fragmentManager) {
             @Override
             protected void cleanup() {
               runningFragments.remove(fragmentHandle);
    -          workBus.removeFragmentManager(fragmentHandle);
    +          if (!fragmentManager.isCancelled()) {
    +            workBus.removeFragmentManager(fragmentHandle, false);
    --- End diff --
    
    Not sure why you don't want to cancel here. 


> For long running queries (> 10 min) Drill may raise FragmentSetupException for completed/cancelled fragments
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5961
>                 URL: https://issues.apache.org/jira/browse/DRILL-5961
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>             Fix For: 1.13.0
>
>
> {{WorkEventBus}} uses {{recentlyFinishedFragments}} cache to check for completed or cancelled fragments. Such check is not reliable as entries in {{recentlyFinishedFragments}} expire after 10 minutes, so {{FragmentSetupException}} is raised even for completed or cancelled queries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)