[GitHub] [openjpa] rmannibucau edited a comment on pull request #65: [OPENJPA-2817] dropping _transforming from PCClassFileTransformer and replace it by a minimal exclusion list

[GitBox <gi...@apache.org>]

rmannibucau edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658324978


   @jgrassel commons is excluded and the jdk as well, just to skip reading the bytecode (which is more costly than this exclusion list if you benchmark both options so overall the fact it is slower or faster depends the classpath size but it is unlikely you notice the difference, in particular with a custom classloader or a default temporary classloader usage which is way slower than that). Also note that the threadlocal option does not work as mentionned so I'm fully open to have another solution but it is better to have a functional solution than nothing I think and I don't have another proposal for now.
   About locking in transform: you can't do that since you would deadlock with the classloader and it is not needed, this is not the issue you hit btw.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org