You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/07/04 10:58:41 UTC
[GitHub] [cordova-plugin-inappbrowser] janpio commented on issue #291:
fix(android): fix crash for target '_system'
janpio commented on issue #291: fix(android): fix crash for target '_system'
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/291#issuecomment-508440615
Remaining test failure is expected.
---
> when the target='_system' it means open the url in system browser.
> so iab will make intent to launch the url action view.
> but on ionic3 native plugin also implements .show() method which is causing the the action to trigger
> dialog.show() method. where the dialog is null. so apps will be crashed with NEP.
How would I reproduce this @Ramachandrajoshi? Does it only work in an Ionic app, or can I somehow also reproduce this with a plain Cordova app?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org