[GitHub] brodybits commented on issue #561: Remove GH-547 update for aidl files

[GitBox <gi...@apache.org>]

brodybits commented on issue #561: Remove GH-547 update for aidl files
URL: https://github.com/apache/cordova-android/pull/561#issuecomment-439043671
 
 
   GH-547 is an issue that is still open. I already proposed a solution in #550 and it was merged. But when I rebased it on 7.1.x and did some more testing I discovered a case where the changes introduced an issue with a plugin. As I said in the OP the reasoning is explained in <https://github.com/apache/cordova-android/issues/547#issuecomment-439016006>.
   
   This PR does the following in a single commit in order to resolve the problem with `https://github.com/j3k0/cordova-plugin-purchase#master`:
   * removes 2 lines from `bin/templates/cordova/lib/pluginHandlers.js` that were added in a67bc75b93f4630e3a5ef9b09ad1ed72aaaa0bbf <a67bc75b93f4630e3a5ef9b09ad1ed72aaaa0bbf> (PR #550)
   * updates a few lines of test code to reflect the change in behavior, in order to resolve the problem with the plugin.
   
   This PR does not revert an entire commit since other changes in the commit (a67bc75b93f4630e3a5ef9b09ad1ed72aaaa0bbf) are needed to resolve GH-547.
   
   An alternative solution could be to revert a67bc75b93f4630e3a5ef9b09ad1ed72aaaa0bbf, which would remove 10 lines from `bin/templates/cordova/lib/pluginHandlers.js` along with a few test changes, and then add the 8 lines we _do_ want in a separate commit.
   
   I would be happy either way and open to suggestions. I have been up for over 24 hours and am looking forward to a resolution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org