[GitHub] [geode] Bill commented on pull request #5334: GEODE-8240: Back-Port to 1.12

[GitBox <gi...@apache.org>]

Bill commented on pull request #5334:
URL: https://github.com/apache/geode/pull/5334#issuecomment-652678946


   > I trust this backport is pretty similar to the GEODE-8240 fix on develop and your PR checks and testing are good.
   > 
   > I am curious what the implications are for users currently running Geode 1.12.0. Should we advise that they upgrade to 1.12.1 to get this fix before attempting to upgrade to 1.13.0?
   
   This fix will be ported to `support/1.13` next. So 1.12.x users will be able to upgrade to the soon-to-be-released 1.13.0 version directly.
   
   > 
   > What about upgrades from 1.11.0 to 1.12.0 or 1.11.0 to 1.12.1?
   
   The bug exists in the 1.12 line before this PR. I think this PR will go into a 1.12.1 or 1.12.2? 
   
   If that's right, then a 1.11.0 to 1.12.0 upgrade will see the bug, and a 1.11.0 to 1.12.1 (or whatever release this PR goes into) will not see the bug.
   
   Incidentally, I don't really know what versions of 1.12 actually exist after 1.12.0. I see a bunch of four-part version numbers here:
   
   <img width="149" alt="image" src="https://user-images.githubusercontent.com/4002/86296758-70d60800-bbae-11ea-96e1-702b5cf75bcc.png">
   
   I don't understand those four-part version numbers.
   
   But I can say that a 1.11.x upgrade to a 1.12.x version that has this fix, will work and the bug will be gone.
   
   > In general does this bug only affect upgrades between minors, or between patch versions too?
   
   My understanding is that Geode usually does not change `Version.CURRENT` between patch releases. On the other hand, I think I have heard that it has been done at least once.
   
   If you upgrade from one patch version to another patch version in the same line and `Version.CURRENT` doesn't change then you won't see this bug.
   
   If you upgrade from one patch version to another patch version in the same line and `Version.CURRENT` _does_ change then you _will_ see this bug.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org