You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Matthew Mulder (Code Review)" <ge...@cloudera.org> on 2017/10/19 21:38:00 UTC
[Impala-ASF-CR] IMPALA-6063: stress test: report test duration
Matthew Mulder has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8339
Change subject: IMPALA-6063: stress test: report test duration
......................................................................
IMPALA-6063: stress test: report test duration
At the end of the stress test, report the number of seconds the test ran
like this:
Test Duration: 1234 seconds
Time spent calculating runtime information isn't counted in the test
duration.
There are some additional changes to simplify the run_queries method
because Flake8 complained that it was too complex and this change
was making it even longer.
Testing:
Ran the stress test and verified the status output and Test Duration
output.
Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
---
M tests/stress/concurrent_select.py
1 file changed, 79 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/8339/1
--
To view, visit http://gerrit.cloudera.org:8080/8339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
Gerrit-Change-Number: 8339
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
[Impala-ASF-CR] IMPALA-6063: stress test: report test duration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8339 )
Change subject: IMPALA-6063: stress test: report test duration
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1353/
--
To view, visit http://gerrit.cloudera.org:8080/8339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
Gerrit-Change-Number: 8339
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Oct 2017 23:01:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6063: stress test: report test duration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8339 )
Change subject: IMPALA-6063: stress test: report test duration
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
Gerrit-Change-Number: 8339
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Oct 2017 03:01:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6063: stress test: report test duration
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8339 )
Change subject: IMPALA-6063: stress test: report test duration
......................................................................
Patch Set 1: Code-Review+2
Your refactoring looks good to my eye, and the new changes look very straightforward.
--
To view, visit http://gerrit.cloudera.org:8080/8339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
Gerrit-Change-Number: 8339
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Oct 2017 23:00:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6063: stress test: report test duration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8339 )
Change subject: IMPALA-6063: stress test: report test duration
......................................................................
IMPALA-6063: stress test: report test duration
At the end of the stress test, report the number of seconds the test ran
like this:
Test Duration: 1234 seconds
Time spent calculating runtime information isn't counted in the test
duration.
There are some additional changes to simplify the run_queries method
because Flake8 complained that it was too complex and this change
was making it even longer.
Testing:
Ran the stress test and verified the status output and Test Duration
output.
Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
Reviewed-on: http://gerrit.cloudera.org:8080/8339
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/stress/concurrent_select.py
1 file changed, 79 insertions(+), 64 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1769c6c27cf064a330026d12d50562abfaf656f
Gerrit-Change-Number: 8339
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Tim Wood <tw...@cloudera.com>