You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ttttttz (Code Review)" <ge...@cloudera.org> on 2023/05/25 11:10:15 UTC

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

ttttttz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19937


Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

When creating single node analytic plan, if the source slot is
non-materialized, this predicate should be filtered out.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
3 files changed, 52 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#6).

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

When creating single node analytic plan, if the source slot is
non-materialized, this predicate should be filtered out.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
3 files changed, 52 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/6
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 7:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13241/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 09 Jun 2023 09:12:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#7).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 536 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/7
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 7
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13144/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 30 May 2023 15:30:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13124/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 1
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 25 May 2023 11:24:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 6:

(2 comments)

Thanks Quanlong! I got it. I just tested both cases: "=" and "between...and".

http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java:

http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@155
PS6, Line 155:       if (e instanceof BinaryPredicate) {
> What about other kinds of predicates? It seems not just BinaryPredicate can
Ack


http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@159
PS6, Line 159:         if (rhs != null && !rhs.isMaterialized()) continue;
> I understand that in this case, the slot is unmaterialized since we don't n
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 31 May 2023 12:52:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test:

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@951
PS4, Line 951: ====
> Needs four "=" instead of three
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 30 May 2023 03:40:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java:

http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@155
PS6, Line 155:       if (e instanceof BinaryPredicate) {
What about other kinds of predicates? It seems not just BinaryPredicate can hit the bug. E.g. I change the predicate to be an InPredicate and it also fails:

  select id,
       RANK() OVER(ORDER BY id DESC) AS rank_id
  from (SELECT id
          FROM functional.alltypesagg
        WHERE int_col in (0, 1) and false) alias_0
  order by id


http://gerrit.cloudera.org:8080/#/c/19937/6/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@159
PS6, Line 159:         if (rhs != null && !rhs.isMaterialized()) continue;
I understand that in this case, the slot is unmaterialized since we don't need to evaluate the conjunct due to short-circuit evaluation on the constant FALSE conjunct. But it might be a bug at somewhere that we don't mark the slot as materialized for a conjunct that we can't skip.

I think the inconsistency happens when we return the conjunct in getUnassignedConjuncts(). If we don't need to evaluate it, we should not consider it anymore. We evaluate the constant conjunct here:
https://github.com/apache/impala/blob/ff3d0c79841b78f99fa78d81b1dca4371cd7bc99/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L1922

I think we should make markConstantConjunct() return boolean values to indicate whether it's constant FALSE. For constant FALSE conjunct, the other conjuncts in the same list should be marked as assigned so they won't be considered anymore.
https://github.com/apache/impala/blob/ff3d0c79841b78f99fa78d81b1dca4371cd7bc99/fe/src/main/java/org/apache/impala/analysis/Analyzer.java#L1893



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 6
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 31 May 2023 07:15:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 13:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13327/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 07:22:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#16).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 524 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/16
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#17).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 526 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/17
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 17:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9413/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 03:51:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 17: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 13:57:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#4).

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

When creating single node analytic plan, if the source slot is
non-materialized, this predicate should be filtered out.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
3 files changed, 53 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 3:

> Uploaded patch set 3.

I triggered a pre-review-test, but some test cases failed. link: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/19425/#showFailuresLink


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 29 May 2023 02:23:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#11).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 522 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/11
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9408/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 23:38:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 15:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13330/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 08:56:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 16:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1886
PS16, Line 1886:     // If a constant FALSE conjunct is found, we don't need to evaluate the other conjuncts
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1906
PS16, Line 1906:     // If a constant FALSE conjunct is found, we don't need to evaluate the other conjuncts
line too long (91 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 11:18:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#3).

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

When creating single node analytic plan, if the source slot is
non-materialized, this predicate should be filtered out.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
3 files changed, 53 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13139/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 30 May 2023 04:01:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#8).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 522 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/8
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 16:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13332/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 16
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 11:40:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 17:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13333/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 11:46:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 12: Code-Review+1

(2 comments)

The new approach looks much better!

http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1887
PS12, Line 1887:     // same list should be marked as assigned.
nit: please add the reason

 // If a constant FALSE conjunct is found, the other conjuncts in the
 // same list should be marked as assigned so they won't be considered anymore in predicate assignment.


http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1906
PS12, Line 1906:     // list should be marked as assigned.
nit: please add the same reason mentioned above



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 00:37:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 17: Code-Review+2

LGTM. Thanks for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 03:51:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13138/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 29 May 2023 12:53:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test:

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@951
PS4, Line 951: ===
Needs four "=" instead of three


http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
File testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test:

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test@146
PS4, Line 146: ,,
duplicate commas



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 30 May 2023 03:31:46 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 8:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13242/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 8
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 09 Jun 2023 09:14:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 13:

(2 comments)

Thanks Quanlong! I have added.

http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1887
PS12, Line 1887:     // same list should be marked as assigned since we don't need to evaluate
> nit: please add the reason
Ack


http://gerrit.cloudera.org:8080/#/c/19937/12/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1906
PS12, Line 1906:     // If a constant FALSE conjunct is found, the other conjuncts in the same
> nit: please add the same reason mentioned above
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 07:02:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 17:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1886
PS16, Line 1886:     // If a constant FALSE conjunct is found, we don't need to evaluate the other
> line too long (91 > 90)
Ack


http://gerrit.cloudera.org:8080/#/c/19937/16/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1906
PS16, Line 1906:     }
> line too long (91 > 90)
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 11:22:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 12: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 12
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Sat, 17 Jun 2023 05:03:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#15).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 524 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/15
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 15
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#13).

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 524 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/13
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 13
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13126/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 3
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 25 May 2023 11:52:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 11:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13309/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 09:54:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19937

to look at the new patch set (#5).

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

When creating single node analytic plan, if the source slot is
non-materialized, this predicate should be filtered out.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
---
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
3 files changed, 53 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19937/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown

Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Filter out non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
File testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test:

http://gerrit.cloudera.org:8080/#/c/19937/4/testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test@146
PS4, Line 146: ,,
> duplicate commas
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 4
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 30 May 2023 03:33:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................

IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

When creating single-node analytic plan, if the plan node is an
EmptySetNode, its tuple ids should not be considered. Also, when
registering conjuncts, if a constant FALSE conjunct is found, the
other conjuncts in the same list should be marked as assigned.

Tests:
 - Add FE and e2e regression tests

Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Reviewed-on: http://gerrit.cloudera.org:8080/19937
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
M testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test
M testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n.test
4 files changed, 526 insertions(+), 8 deletions(-)

Approvals:
  Quanlong Huang: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 18
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>

[Impala-ASF-CR] IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )

Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown
......................................................................


Patch Set 17: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f
Gerrit-Change-Number: 19937
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <24...@qq.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 09:09:16 +0000
Gerrit-HasComments: No