You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/02/23 17:17:33 UTC

[GitHub] [couchdb-nano] kelfish opened a new pull request #258: Add type definitions for changesReader methods

kelfish opened a new pull request #258:
URL: https://github.com/apache/couchdb-nano/pull/258


   ## Overview
   
   Adds missing Typescript definitions for `changesReader` methods that are implemented and referenced in the documentation. These are `pause()` and `resume()` which currently cause type check issues if using Typescript with `nano`.
   
   ## Testing recommendations
   
   Implement a `wait: true` changes reader with `nano` in a `Typescript` module. Attempting to use `resume()` after processing a change causes a type error when running a type check:
   
   `tsc -p .`
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #258: Add type definitions for changesReader methods

Posted by GitBox <gi...@apache.org>.

glynnbird merged pull request #258:
URL: https://github.com/apache/couchdb-nano/pull/258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org